Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 934644 - app-editors/vscodium: Taskbar not showing correct icon
Summary: app-editors/vscodium: Taskbar not showing correct icon
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Adel KARA SLIMANE
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-21 05:22 UTC by Mike Bryce
Modified: 2024-12-28 08:33 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Bryce 2024-06-21 05:22:17 UTC
The vscodium window has the wrong desktopName value set, so the taskbar shows the generic wayland icon.

This apparently happens because of the following lines in the package's build/gulpfile.vscode.js file:

// for linux url handling
if (platform === 'linux') {
    packageJsonUpdates.desktopName = `${product.applicationName}-url-handler.desktop`;
}

That creates the package.json file that is installed at /opt/vscodium/resources/app/package.json with the incorrect desktopName entry.

If I manually edit this entry to match the name of the .desktop file, the icon shows correctly.

Further info from Solus developer at:
https://github.com/microsoft/vscode/issues/154693#issuecomment-1944230699
Comment 1 Larry the Git Cow gentoo-dev 2024-12-28 08:33:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a06a76a93b339f98ed6d9365e909ed026ae1b0de

commit a06a76a93b339f98ed6d9365e909ed026ae1b0de
Author:     Adel KARA SLIMANE <adel.ks@zegrapher.com>
AuthorDate: 2024-12-26 02:01:17 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2024-12-28 08:32:35 +0000

    app-editors/vscodium: .desktop file fixups
    
    Closes: https://bugs.gentoo.org/934644
    Closes: https://bugs.gentoo.org/936208
    
    Signed-off-by: Adel KARA SLIMANE <adel.ks@zegrapher.com>
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 ...-handler.desktop => codium-url-handler.desktop} |  2 +-
 app-editors/vscodium/files/codium.desktop          | 27 ++++++++++++++++++++++
 app-editors/vscodium/files/vscodium.desktop        | 18 ---------------
 app-editors/vscodium/vscodium-1.96.0.24347.ebuild  | 12 +++++-----
 app-editors/vscodium/vscodium-1.96.2.24355.ebuild  | 12 +++++-----
 5 files changed, 40 insertions(+), 31 deletions(-)