Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 934537 - sys-kernel/linux-firmware should skip compression for more firmware files
Summary: sys-kernel/linux-firmware should skip compression for more firmware files
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Chí-Thanh Christopher Nguyễn
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-06-19 08:14 UTC by Alexander Tsoy
Modified: 2024-06-30 17:31 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Tsoy 2024-06-19 08:14:01 UTC 
Currently compression is skipped only for AMD microcode, but we should skip it for all files labeled as RawFile in WHENCE.

# grep RawFile WHENCE 
RawFile: amd-ucode/microcode_amd.bin
RawFile: amd-ucode/microcode_amd_fam15h.bin
RawFile: amd-ucode/microcode_amd_fam16h.bin
RawFile: amd-ucode/microcode_amd_fam17h.bin
RawFile: amd-ucode/microcode_amd_fam19h.bin
RawFile: qcom/apq8096/adspr.jsn
RawFile: qcom/apq8096/adspua.jsn
RawFile: qcom/apq8096/modemr.jsn
RawFile: qcom/qcm2290/adspr.jsn
RawFile: qcom/qcm2290/adsps.jsn
RawFile: qcom/qcm2290/adspua.jsn
RawFile: qcom/qcm2290/modemr.jsn
RawFile: qcom/qcm2290/modemuw.jsn
RawFile: qcom/qrb4210/adspr.jsn
RawFile: qcom/qrb4210/adsps.jsn
RawFile: qcom/qrb4210/adspua.jsn
RawFile: qcom/qrb4210/cdspr.jsn
RawFile: qcom/qrb4210/modemr.jsn
RawFile: qcom/qrb4210/modemuw.jsn
RawFile: qcom/sdm845/adspr.jsn
RawFile: qcom/sdm845/adspua.jsn
RawFile: qcom/sdm845/cdspr.jsn
RawFile: qcom/sdm845/Thundercomm/db845c/slpir.jsn
RawFile: qcom/sdm845/Thundercomm/db845c/slpius.jsn
RawFile: qcom/sm8250/adspr.jsn
RawFile: qcom/sm8250/adspua.jsn
RawFile: qcom/sm8250/cdspr.jsn
RawFile: qcom/sm8250/Thundercomm/RB5/slpir.jsn
RawFile: qcom/sm8250/Thundercomm/RB5/slpius.jsn
RawFile: qcom/sc8280xp/LENOVO/21BX/adspr.jsn
RawFile: qcom/sc8280xp/LENOVO/21BX/adspua.jsn
RawFile: qcom/sc8280xp/LENOVO/21BX/battmgr.jsn
RawFile: qcom/sc8280xp/LENOVO/21BX/cdspr.jsn
RawFile: qcom/sdm845/modemuw.jsn
Comment 1 Larry the Git Cow gentoo-dev 2024-06-30 17:31:17 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=58b118816d567fdffaaaf589c49f33268d12cae4

commit 58b118816d567fdffaaaf589c49f33268d12cae4
Author:     Alexander Tsoy <alexander@tsoy.me>
AuthorDate: 2024-06-19 07:50:43 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-06-30 17:25:04 +0000

    sys-kernel/linux-firmware: compress firmwares via copy-firmware.sh
    
    Currently we only skip compression for AMD microcode, but we should skip
    it for all files labeled as RawFile in WHENCE. copy-firmware.sh gained
    support for compressing firmware files at some point and it does it
    right.
    
    A notable consequence of this change is that saved config now contains
    file names with compression extension.
    
    Closes: https://bugs.gentoo.org/934537
    Signed-off-by: Alexander Tsoy <alexander@tsoy.me>
    Closes: https://github.com/gentoo/gentoo/pull/37213
    Signed-off-by: Sam James <sam@gentoo.org>

 .../linux-firmware-20240610-r2.ebuild              | 396 +++++++++++++++++++++
 .../linux-firmware/linux-firmware-99999999.ebuild  |  44 +--
 2 files changed, 408 insertions(+), 32 deletions(-)