Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 934122 - sci-libs/cgnslib-4.4.0-r1[tools]: error: implicit declaration of function ‘TkWmAddToColormapWindows’
Summary: sci-libs/cgnslib-4.4.0-r1[tools]: error: implicit declaration of function ‘Tk...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Science Related Packages
URL:
Whiteboard: fixed in 4.4.0-r2
Keywords: PATCH
: 933088 (view as bug list)
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2024-06-12 07:12 UTC by Petr Šourek
Modified: 2024-11-01 16:13 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log.txt,15.75 KB, text/plain)
2024-06-12 07:12 UTC, Petr Šourek
Details
emerge --info '=sci-libs/cgnslib-4.4.0-r1::gentoo' (emerge.info.txt,9.51 KB, text/plain)
2024-06-12 07:13 UTC, Petr Šourek
Details
emerge -pqv '=sci-libs/cgnslib-4.4.0-r1::gentoo' (pvq.txt,133 bytes, text/plain)
2024-06-12 07:13 UTC, Petr Šourek
Details
environment (environment.txt,99.77 KB, text/plain)
2024-06-12 07:13 UTC, Petr Šourek
Details
fedoraGCCPatch, with hardcoded path to TK include paths (fedoraGCCPatch.patch,1.77 KB, patch)
2024-06-17 16:06 UTC, Petr Šourek
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Šourek 2024-06-12 07:12:36 UTC
Created attachment 895679 [details]
build.log

Hello,

This build fail throwing this error.

FAILED: src/cgnstools/cgnsplot/tkogl/CMakeFiles/tkogl.dir/tkogl.c.o 
/usr/bin/x86_64-pc-linux-gnu-gcc  -I/var/tmp/portage/sci-libs/cgnslib-4.4.0-r1/work/CGNS-4.4.0/src/cgnstools/tkogl/../common  -O2 -pipe -march=broadwell -mtune=broadwell -fomit-frame-pointer -std=gnu99 -std=gnu99 -MD -MT src/cgnstools/cgnsplot/tkogl/CMakeFiles/tkogl.dir/tkogl.c.o -MF src/cgnstools/cgnsplot/tkogl/CMakeFiles/tkogl.dir/tkogl.c.o.d -o src/cgnstools/cgnsplot/tkogl/CMakeFiles/tkogl.dir/tkogl.c.o -c /var/tmp/portage/sci-libs/cgnslib-4.4.0-r1/work/CGNS-4.4.0/src/cgnstools/tkogl/tkogl.c
/var/tmp/portage/sci-libs/cgnslib-4.4.0-r1/work/CGNS-4.4.0/src/cgnstools/tkogl/tkogl.c: In function ‘OGLwinCmd’:
/var/tmp/portage/sci-libs/cgnslib-4.4.0-r1/work/CGNS-4.4.0/src/cgnstools/tkogl/tkogl.c:602:8: error: implicit declaration of function ‘TkWmAddToColormapWindows’ [-Wimplicit-function-declaration]

Thanks,
Regards,
Petr Sourek
Comment 1 Petr Šourek 2024-06-12 07:13:16 UTC
Created attachment 895680 [details]
emerge --info '=sci-libs/cgnslib-4.4.0-r1::gentoo'
Comment 2 Petr Šourek 2024-06-12 07:13:34 UTC
Created attachment 895681 [details]
emerge -pqv '=sci-libs/cgnslib-4.4.0-r1::gentoo'
Comment 3 Petr Šourek 2024-06-12 07:13:47 UTC
Created attachment 895682 [details]
environment
Comment 4 Petr Šourek 2024-06-17 16:05:16 UTC
I have found out, that there should be patch (https://patch-diff.githubusercontent.com/raw/CGNS/CGNS/pull/757.patch) for it. But then I am stuck on this error, which don't see the tkInt.h file in /usr/lib/tk8.6/include path.

FAILED: src/cgnstools/cgnsplot/tkogl/CMakeFiles/tkogl.dir/tkogl.c.o 
/usr/bin/x86_64-pc-linux-gnu-gcc  -I/var/tmp/portage/sci-libs/cgnslib-4.4.0-r1/work/CGNS-4.4.0/src/cgnstools/tkogl/../common  -O2 -pipe -march=broadwell -mtune=broadwell -fomit-frame-pointer -std=gnu99 -std=gnu99 -MD -MT src/cgnstools/cgnsplot/tkogl/CMakeFiles/tkogl.dir/tkogl.c.o -MF src/cgnstools/cgnsplot/tkogl/CMakeFiles/tkogl.dir/tkogl.c.o.d -o src/cgnstools/cgnsplot/tkogl/CMakeFiles/tkogl.dir/tkogl.c.o -c /var/tmp/portage/sci-libs/cgnslib-4.4.0-r1/work/CGNS-4.4.0/src/cgnstools/tkogl/tkogl.c
/var/tmp/portage/sci-libs/cgnslib-4.4.0-r1/work/CGNS-4.4.0/src/cgnstools/tkogl/tkogl.c:28:10: fatal error: tk-private/generic/tkInt.h: No such file or directory
   28 | #include <tk-private/generic/tkInt.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

TBH: Since I need my system to be repaired (some Qt related stuff and dependencies), I took the patch, changed the tk-private to path to my include dir and it works fine (attaching now), but maybee someone smarter should make it dynamic.

Thanks,
Regards,
Petr Sourek
Comment 5 Petr Šourek 2024-06-17 16:06:13 UTC
Created attachment 895952 [details, diff]
fedoraGCCPatch, with hardcoded path to TK include paths
Comment 6 Leonid Kopylov 2024-06-20 03:34:48 UTC
same as https://bugs.gentoo.org/933088 - it builds with gcc 13
Comment 7 Attila Tóth 2024-10-02 10:20:34 UTC
(In reply to Petr Šourek from comment #5)
> Created attachment 895952 [details, diff] [details, diff]
> fedoraGCCPatch, with hardcoded path to TK include paths

Patch works for me with one modification in case of my profile: the hardcoded path should contain lib64 instead of lib.
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-10-05 07:16:44 UTC
*** Bug 933088 has been marked as a duplicate of this bug. ***
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-10-05 07:22:15 UTC
I'll take a look.
Comment 10 Larry the Git Cow gentoo-dev 2024-10-05 08:15:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9acc8d665d245b46d3c8c7e864337c2ee0f41351

commit 9acc8d665d245b46d3c8c7e864337c2ee0f41351
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-10-05 08:15:01 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-10-05 08:15:24 +0000

    sci-libs/cgnslib: fix modern C issues
    
    Closes: https://bugs.gentoo.org/934122
    Signed-off-by: Sam James <sam@gentoo.org>

 sci-libs/cgnslib/cgnslib-4.4.0-r2.ebuild       | 106 +++++++++++++++++++++++++
 sci-libs/cgnslib/files/cgnslib-4.4.0-c99.patch |  55 +++++++++++++
 2 files changed, 161 insertions(+)