934062 – dev-libs/protobuf-23.3-r4, dev-cpp/abseil-cpp-20230125.3-r3, dev-python/protobuf-python-4.23.3, dev-java/protobuf-java-3.23.3: stabilisation

Bug 934062 - dev-libs/protobuf-23.3-r4, dev-cpp/abseil-cpp-20230125.3-r3, dev-python/protobuf-python-4.23.3, dev-java/protobuf-java-3.23.3: stabilisation

Summary: dev-libs/protobuf-23.3-r4, dev-cpp/abseil-cpp-20230125.3-r3, dev-python/proto...

Status:	IN_PROGRESS

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Stabilization (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it

URL:
Whiteboard:
Keywords:	CC-ARCHES

Depends on:	915902
Blocks:	933068
	Show dependency tree

Reported:	2024-06-11 17:01 UTC by Sam James
Modified:	2024-06-17 00:17 UTC (History)
CC List:	7 users (show)

See Also:
Package list:	dev-libs/protobuf-23.3-r4 dev-cpp/abseil-cpp-20230125.3-r3 dev-java/protobuf-java-3.23.3 amd64 ppc64 x86 dev-python/protobuf-python-4.23.3 amd64 arm arm64 ppc64 x86
Runtime testing required:	---

Flags:	nattka: sanity-check+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Sam James archtester

2024-06-11 17:01:24 UTC

I _think_ we can do this one now without the abseil mess.

Comment 1 NATTkA bot gentoo-dev

2024-06-11 17:04:20 UTC Comment hidden (obsolete)

Sanity check failed:

> dev-libs/protobuf-22.5
>   depend arm stable profile default/linux/arm/23.0 (20 total)
>     <dev-cpp/abseil-cpp-20240116.2:=[test]
>     >=dev-cpp/abseil-cpp-20230125:=[test]
>   depend arm dev profile default/linux/arm/23.0/armv4 (56 total)
>     <dev-cpp/abseil-cpp-20240116.2:=[test]
>     >=dev-cpp/abseil-cpp-20230125:=[test]
>   rdepend arm stable profile default/linux/arm/23.0 (20 total)
>     <dev-cpp/abseil-cpp-20240116.2:=
>     >=dev-cpp/abseil-cpp-20230125:=
>   rdepend arm dev profile default/linux/arm/23.0/armv4 (56 total)
>     <dev-cpp/abseil-cpp-20240116.2:=
>     >=dev-cpp/abseil-cpp-20230125:=

Comment 2 Sam James archtester

2024-06-11 17:08:45 UTC

Or not.

Comment 3 Arthur Zamarin archtester

2024-06-12 05:31:59 UTC

ppc64 done

Comment 4 Larry the Git Cow gentoo-dev

2024-06-13 01:56:16 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1404a03d55630c51f06dd0c9b9aa4975c05894b5

commit 1404a03d55630c51f06dd0c9b9aa4975c05894b5
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-06-13 01:54:59 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-06-13 01:54:59 +0000

    dev-libs/protobuf: loosen abseil-cpp dependency
    
    abseil-cpp now unconditionally installs its test helper libraries.
    
    Bug: https://bugs.gentoo.org/915902
    Bug: https://bugs.gentoo.org/934062
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/protobuf/{protobuf-22.5.ebuild => protobuf-22.5-r1.ebuild}   | 4 ++--
 .../protobuf/{protobuf-23.3-r2.ebuild => protobuf-23.3-r3.ebuild}     | 4 ++--
 dev-libs/protobuf/{protobuf-26.1.ebuild => protobuf-26.1-r1.ebuild}   | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=53bb853b51f0ccdacba1714a9405e23fbdd96ce2

commit 53bb853b51f0ccdacba1714a9405e23fbdd96ce2
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-06-13 01:53:21 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-06-13 01:53:21 +0000

    dev-cpp/abseil-cpp: unconditionally install test helper libraries
    
    dev-libs/protobuf needs it at least and depending on USE=test for
    it is considered odd.
    
    Bug: https://bugs.gentoo.org/915902
    Bug: https://bugs.gentoo.org/934062
    Signed-off-by: Sam James <sam@gentoo.org>

 ...seil-cpp-20230125.3-r1.ebuild => abseil-cpp-20230125.3-r2.ebuild} | 5 +++--
 ...{abseil-cpp-20230802.0.ebuild => abseil-cpp-20230802.0-r1.ebuild} | 5 +++--
 ...{abseil-cpp-20240116.2.ebuild => abseil-cpp-20240116.2-r1.ebuild} | 3 ++-
 3 files changed, 8 insertions(+), 5 deletions(-)

Comment 5 NATTkA bot gentoo-dev

2024-06-13 02:00:14 UTC Comment hidden (obsolete)

Unable to check for sanity:

> no match for package: dev-cpp/abseil-cpp-20230125.2-r1

Comment 6 Larry the Git Cow gentoo-dev

2024-06-13 04:09:39 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=247aeb9cf521d95a853d52a7b1f4719f508a0ffd

commit 247aeb9cf521d95a853d52a7b1f4719f508a0ffd
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-06-13 04:08:21 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-06-13 04:09:17 +0000

    dev-libs/protobuf: fix tests
    
    'full-test' requires this. TestSourceDir in src/google/protobuf/testing/googletest.cc
    respects 'srcdir' as an env var as a hint.
    
    Bug: https://bugs.gentoo.org/934062
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/protobuf/protobuf-22.5-r1.ebuild | 5 +++++
 dev-libs/protobuf/protobuf-23.3-r3.ebuild | 5 +++++
 dev-libs/protobuf/protobuf-26.1-r1.ebuild | 5 +++++
 3 files changed, 15 insertions(+)

Comment 7 Sam James archtester

2024-06-13 04:10:10 UTC

amd64 done

Comment 8 Larry the Git Cow gentoo-dev

2024-06-13 04:53:50 UTC

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=de15b02f0b35c97ba57195624a582d191b038812

commit de15b02f0b35c97ba57195624a582d191b038812
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-06-13 04:52:49 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-06-13 04:53:00 +0000

    dev-python/protobuf-python: fix tests
    
    Bug: https://bugs.gentoo.org/934062
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/protobuf-python-4.22.5-python.patch       | 21 +++++++++++++++++++++
 .../protobuf-python/protobuf-python-4.22.5.ebuild   |  1 +
 2 files changed, 22 insertions(+)

Comment 9 Joonas Niilola gentoo-dev

2024-06-13 06:46:23 UTC

Still hitting bug 857570 on x86 with dev-python/protobuf-python-4.22.5 - not sure if it's critical enough to make it a blocker again?

Comment 10 Paul Zander 2024-06-13 23:52:58 UTC

The test failure is a result from converting between signed and unsigned. The bit patterns of 4294967295 and -1 are equal.

Comment 11 NATTkA bot gentoo-dev

2024-06-14 21:28:31 UTC Comment hidden (obsolete)

Sanity check failed:

> dev-libs/protobuf-23.3-r4
>   depend arm stable profile default/linux/arm/23.0 (20 total)
>     <dev-cpp/abseil-cpp-20240116.2:=
>     >=dev-cpp/abseil-cpp-20230125.3:=
>   depend arm dev profile default/linux/arm/23.0/armv4 (56 total)
>     <dev-cpp/abseil-cpp-20240116.2:=
>     >=dev-cpp/abseil-cpp-20230125.3:=
>   rdepend arm stable profile default/linux/arm/23.0 (20 total)
>     <dev-cpp/abseil-cpp-20240116.2:=
>     >=dev-cpp/abseil-cpp-20230125.3:=
>   rdepend arm dev profile default/linux/arm/23.0/armv4 (56 total)
>     <dev-cpp/abseil-cpp-20240116.2:=
>     >=dev-cpp/abseil-cpp-20230125.3:=

Comment 12 Sam James archtester

2024-06-15 07:09:36 UTC

amd64 done

Comment 13 Joonas Niilola gentoo-dev

2024-06-15 08:13:09 UTC

x86 done

Comment 14 Piotr Kubaj 2024-06-16 23:44:45 UTC

This breaks build of app-i18n/mozc:
/usr/bin/x86_64-pc-linux-gnu-g++ -MMD -MF obj/unix/fcitx/fcitx-mozc.eim.o.d -DOS_LINUX -DMOZC_BUILD -DCHANNEL_DEV '-DLOCALEDIR="/usr/share/locale/"' -DNDEBUG -DQT_NO_DEBUG -DMOZC_NO_LOGGING -DIGNORE_HELP_FLAG -DIGNORE_INVALID_FLAG -I/var/tmp/portage/app-i18n/mozc-2.28.5029.102/work/mozc-2.28.5029.102/src -Igen -Igen/proto_out -fmessage-length=0 -fno-strict-aliasing -funsigned-char -pipe -pthread -fno-omit-frame-pointer -fstack-protector --param=ssp-buffer-size=4 -Wall -Wno-char-subscripts -Wno-sign-compare -Wno-deprecated-declarations -Wwrite-strings -Wno-unknown-warning-option -Wno-inconsistent-missing-override -fPIC -fno-exceptions -Wtype-limits -O2 -pipe -march=native -fgraphite-identity -floop-nest-optimize -flto=auto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Wno-deprecated -Wno-covered-switch-default -Wno-unnamed-type-template-args -Wno-c++11-narrowing -std=c++17  -c ../../unix/fcitx/eim.cc -o obj/unix/fcitx/fcitx-mozc.eim.o
In file included from /usr/include/absl/functional/function_ref.h:54,
                 from /usr/include/absl/strings/cord.h:80,
                 from /usr/include/google/protobuf/io/coded_stream.h:134,
                 from gen/proto_out/protocol/commands.pb.h:24,
                 from ../../unix/fcitx/fcitx_mozc.h:43,
                 from ../../unix/fcitx/eim.cc:36:
/usr/include/absl/functional/internal/function_ref.h:78:68: error: macro "InvokeFunction" requires 4 arguments, but only 2 given
   78 | R InvokeFunction(VoidPtr ptr, typename ForwardT<Args>::type... args) {
      |                                                                    ^
In file included from ../../unix/fcitx/eim.cc:33:
/usr/include/fcitx/module.h:131: note: macro "InvokeFunction" defined here
  131 | #define InvokeFunction(INST, MODULE, FUNC, ARG)                         \
      | 
/usr/include/absl/functional/internal/function_ref.h:79:3: error: expected primary-expression before ‘auto’
   79 |   auto f = reinterpret_cast<Fun>(ptr.fun);
      |   ^~~~
/usr/include/absl/functional/internal/function_ref.h:79:3: error: expected ‘}’ before ‘auto’
/usr/include/absl/functional/internal/function_ref.h:78:70: note: to match this ‘{’
   78 | R InvokeFunction(VoidPtr ptr, typename ForwardT<Args>::type... args) {
      |                                                                      ^
/usr/include/absl/functional/internal/function_ref.h:78:71: error: expected ‘;’ before ‘auto’
   78 | R InvokeFunction(VoidPtr ptr, typename ForwardT<Args>::type... args) {
      |                                                                       ^
      |                                                                       ;
   79 |   auto f = reinterpret_cast<Fun>(ptr.fun);
      |   ~~~~                                                                 
/usr/include/absl/functional/internal/function_ref.h:80:3: error: expected unqualified-id before ‘return’
   80 |   return static_cast<R>(
      |   ^~~~~~
/usr/include/absl/functional/internal/function_ref.h:104:1: error: expected declaration before ‘}’ token
  104 | }  // namespace absl
      | ^
/usr/include/absl/functional/function_ref.h:118:7: error: ‘absl::lts_20230125::functional_internal::EnableIf’ has not been declared
  118 |       absl::functional_internal::EnableIf<absl::is_function<F>::value> = 0>
      |       ^~~~
/usr/include/absl/functional/function_ref.h:118:42: error: expected ‘>’ before ‘<’ token
  118 |       absl::functional_internal::EnableIf<absl::is_function<F>::value> = 0>
      |                                          ^
/usr/include/absl/functional/function_ref.h: In constructor ‘absl::lts_20230125::FunctionRef<R(Args ...)>::FunctionRef(const F&)’:
/usr/include/absl/functional/function_ref.h:106:32: error: ‘AssertNonNull’ is not a member of ‘absl::lts_20230125::functional_internal’; did you mean ‘absl::lts_20230125::AssertNonNull’?
  106 |     absl::functional_internal::AssertNonNull(f);
      |                                ^~~~~~~~~~~~~
/usr/include/absl/functional/internal/function_ref.h:94:6: note: ‘absl::lts_20230125::AssertNonNull’ declared here
   94 | void AssertNonNull(F C::*f) {
      |      ^~~~~~~~~~~~~

Comment 15 Sam James archtester

2024-06-17 00:17:07 UTC

Please file a new bug.