Bug 934044 – dev-games/godot-4.2.2[upnp] with net-libs/miniupnpc-2.2.8-r1 : error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDdatas*, char*, int, char*, int)’

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Alfred Wingate 2024-06-11 13:31:48 UTC]

Created attachment 895565 [details]
dev-games/godot-4.2.2 build.log (xz compressed)

x86_64-pc-linux-gnu-g++ -o thirdparty/vhacd/src/FloatMath.linuxbsd.template_release.x86_64.runner.o -c -std=gnu++1
7 -O3 -march=znver2 -pipe -fuse-linker-plugin -frecord-gcc-switches -Werror=odr -Werror=lto-type-mismatch -Werror=
strict-aliasing -fno-lto -fno-lto -Wno-error=odr -fno-exceptions -pipe -pthread -Wall -Wshadow -Wno-misleading-ind
entation -Wno-return-type -w -isystem thirdparty/glad -DNDEBUG -DNO_EDITOR_SPLASH -DDISABLE_DEPRECATED -DTOUCH_ENA
BLED -DFONTCONFIG_ENABLED -DALSA_ENABLED -DALSAMIDI_ENABLED -D_REENTRANT -DPULSEAUDIO_ENABLED -DDBUS_ENABLED -DXKB
_ENABLED -DJOYDEV_ENABLED -DUDEV_ENABLED -DLINUXBSD_ENABLED -DUNIX_ENABLED -D_FILE_OFFSET_BITS=64 -DX11_ENABLED -D
VULKAN_ENABLED -DGLES3_ENABLED -DMINIZIP_ENABLED -DBROTLI_ENABLED -DCLIPPER2_ENABLED -DVK_USE_PLATFORM_XLIB_KHR -D
GLAD_ENABLED -DEGL_ENABLED -Ithirdparty/vhacd/inc -Ithirdparty/vulkan -Ithirdparty/vulkan/include -Ithirdparty/cli
pper2/include -Iplatform/linuxbsd -I/usr/include/recastnavigation -I/usr/include/miniupnpc -I. -I/usr/include/free
type2 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libpng16 -I/usr
/include/webp -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/elogind thirdparty/vhacd/src/Fl
oatMath.cpp
modules/upnp/upnp.cpp: In member function ‘void UPNP::parse_igd(Ref<UPNPDevice>, UPNPDev*)’:
modules/upnp/upnp.cpp:147:33: error: too few arguments to function ‘int UPNP_GetValidIGD(UPNPDev*, UPNPUrls*, IGDd
atas*, char*, int, char*, int)’
  147 |         int i = UPNP_GetValidIGD(devlist, urls, &data, (char *)&addr, 16);
      |                 ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from modules/upnp/upnp.h:38:
/usr/include/miniupnpc/miniupnpc.h:122:1: note: declared here
  122 | UPNP_GetValidIGD(struct UPNPDev * devlist,
      | ^~~~~~~~~~~~~~~~

[Comment 1 Alfred Wingate 2024-06-11 13:32:07 UTC]

Created attachment 895566 [details]
emerge --info

[Comment 2 Alfred Wingate 2024-06-11 13:36:03 UTC]

Commit that changed the api:
https://github.com/miniupnp/miniupnp/commit/c0a50ce33e3b99ce8a96fd43049bb5b53ffac62f

[Comment 3 Larry the Git Cow 2024-06-11 14:46:19 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a65ce2b064d82640943d74b5cc72bba9674dceb5

commit a65ce2b064d82640943d74b5cc72bba9674dceb5
Author:     Ionen Wolkens <[e-mail]>
AuthorDate: 2024-06-11 14:21:54 +0000
Commit:     Ionen Wolkens <[e-mail]>
CommitDate: 2024-06-11 14:45:05 +0000

    dev-games/godot: use bundled miniupnpc for now
    
    Likely an easy fix, but no time to look at this right now and
    would rather not set a upper bound given hard to say how long this
    will stay broken as upstream relies on the bundled copy.
    
    Will check if can revert this on bump.
    
    Closes: https://bugs.gentoo.org/934044
    Signed-off-by: Ionen Wolkens <[e-mail]>

 dev-games/godot/{godot-3.5.3.ebuild => godot-3.5.3-r1.ebuild} | 6 +++---
 dev-games/godot/{godot-4.2.2.ebuild => godot-4.2.2-r1.ebuild} | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

[Comment 4 Larry the Git Cow 2025-03-04 02:46:32 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=66ddfc523335615aa56f9235d92ac1fa2bd1b46e

commit 66ddfc523335615aa56f9235d92ac1fa2bd1b46e
Author:     Ionen Wolkens <[e-mail]>
AuthorDate: 2025-03-04 01:07:52 +0000
Commit:     Ionen Wolkens <[e-mail]>
CommitDate: 2025-03-04 02:45:18 +0000

    dev-games/godot: add 4.4
    
    Use system miniupnpc again wrt bug #934044, and can also use
    mbedtls:3 properly now (while it *can* still use mbedtls:0,
    force :3 for simplicity with the slotting logic).
    
    platform/linuxbsd.detect.py newly prints a warning when using
    system icu4c or harfbuzz that it may cause problems, but issue
    seems nebulous and unclear if we're affected and opted to ignore
    it for now (aka, keep using system's).
    
    Hopefully not overlooked anything, build system diff has a lot
    of noise making it hard to pickup important changes.
    
    Bug: https://bugs.gentoo.org/934044
    Signed-off-by: Ionen Wolkens <[e-mail]>

 dev-games/godot/Manifest                    |   1 +
 dev-games/godot/files/godot-4.4-scons.patch |  15 ++
 dev-games/godot/godot-4.4.ebuild            | 230 ++++++++++++++++++++++++++++
 3 files changed, 246 insertions(+)