Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 933992 - games-action/descent2-data ebuild update fixing xdelta readme.txt dirs
Summary: games-action/descent2-data ebuild update fixing xdelta readme.txt dirs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-10 07:54 UTC by Jon Daniel
Modified: 2024-06-14 22:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
games-action/descent2-data ebuild update fixing xdelta readme.txt dirs (descent2-data-1.2-r2.ebuild,3.11 KB, application/vnd.gentoo.ebuild)
2024-06-10 07:54 UTC, Jon Daniel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Daniel 2024-06-10 07:54:54 UTC
Created attachment 895492 [details]
games-action/descent2-data ebuild update fixing xdelta readme.txt dirs

Update fixing xdelta readme.txt directories
Comment 1 James Le Cuirot gentoo-dev 2024-06-11 16:35:13 UTC
Hmmm. I lost the CD very long ago, so I probably never tested this code path, but presumably it worked for the person who originally wrote it. Hard to see how it could work now though. Does it actually break for you or does it just skip over the readme patch?
Comment 2 Jon Daniel 2024-06-12 20:29:54 UTC
emerging doesn't complete the install procedure and fails without my changes.
Comment 3 Larry the Git Cow gentoo-dev 2024-06-14 22:26:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dc3715e54ff4f1549576cd25fb6abeaeb7f9ef11

commit dc3715e54ff4f1549576cd25fb6abeaeb7f9ef11
Author:     James Le Cuirot <chewi@gentoo.org>
AuthorDate: 2024-06-14 22:25:24 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2024-06-14 22:25:24 +0000

    games-action/descent2-data: Fix patching the CD readme file
    
    Closes: https://bugs.gentoo.org/933992
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 games-action/descent2-data/descent2-data-1.2-r1.ebuild | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
Comment 4 James Le Cuirot gentoo-dev 2024-06-14 22:26:47 UTC
I was able to obtain the CD image and verify for myself. I ended up fixing it in a slightly different way, but thanks for raising the issue.