Hello: I added a new use flag to the current syncthing package, so that it can install application profile to net-firewall/ufw. I changed the ebuild file to add a check if ufw IUSE is enabled. If it is, we install the application profile at ${FILESDIR}/syncthing.ufw to /etc/ufw/applications.d/ The github pull request for this is available at the URL I specified. Thanks. Ryan
Created attachment 895489 [details, diff] 1.27.6-r1.patch This patch adds the functionality that I mentioned before, And should be the same as the github pull request
Thanks, I'll merge this shortly (will take your word for it that the application profile itself is correct, as I do not use ufw). Mind you, in your future please refrain from making multiple independent changes - such as both adding a new USE flag to a package and reindenting metadata.xml, as it has been the case here - in a single commit. One logical change per commit, please!
I am about to push 1.27.8 to the tree and it installs the ufw profile for Syncthing. Thank you again! Two more comments about your patch, for future reference: - this may or may not be a bit obscure (can't recall what the current version of devmanual has got to say about it) but the present-day rule for introducing new USE flags is not to if all they do is install "small" files. The ufw profile is only 175 bytes long so it might as well be installed unconditionally - the profile in question is included in the Syncthing release tarballs, no need to add it to FILESDIR.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=35b15dad1e5d3397aae68a56a06a01c9edfd747f commit 35b15dad1e5d3397aae68a56a06a01c9edfd747f Author: Marek Szuba <marecki@gentoo.org> AuthorDate: 2024-06-14 13:29:48 +0000 Commit: Marek Szuba <marecki@gentoo.org> CommitDate: 2024-06-14 13:33:38 +0000 net-p2p/syncthing: add 1.27.8 Closes: https://bugs.gentoo.org/933985 Signed-off-by: Marek Szuba <marecki@gentoo.org> net-p2p/syncthing/Manifest | 1 + net-p2p/syncthing/syncthing-1.27.8.ebuild | 116 ++++++++++++++++++++++++++++++ 2 files changed, 117 insertions(+)
(In reply to Marek Szuba from comment #3) > - this may or may not be a bit obscure (can't recall what the current > version of devmanual has got to say about it) but the present-day rule for > introducing new USE flags is not to if all they do is install "small" files. > The ufw profile is only 175 bytes long so it might as well be installed > unconditionally Thanks for the tips and corrections :) That was my fault, the rule is indeed in the gentoo devmanual, I didn't check them thoroughly. At the time of writing, I simply copied what others was doing, in this case net-misc/mosh, which has a ufw use flag that installs a small file. I will check that package later and try to come up with a patch that aligns with the "not to add use flag" rule.
