Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 933864 - app-admin/conky-1.21.2 BUILD_XINPUT disabled by default
Summary: app-admin/conky-1.21.2 BUILD_XINPUT disabled by default
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Daniel Pielmeier
URL: https://github.com/brndnmtthws/conky/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-09 08:58 UTC by Bug Bugs
Modified: 2024-06-27 19:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bug Bugs 2024-06-09 08:58:37 UTC
FYI
https://github.com/brndnmtthws/conky/pull/1920
> Causes performance issues for some people (running multiple instances at once?).

For people not using "action" conky (monitoring only) both `BUILD_XINPUT` and `BUILD_MOUSE_EVENTS` makes no sense and consumes cpu cycles for no reason.

Please add use flag to disable those (currently hardcoded in ebuild).

Reproducible: Always

Steps to Reproduce:
1. Run conky w/ top cpu (or whatever top)
2. Move mouse / hit keys
3. See top spikes (no reaction w/ disabled events)
Actual Results:  
~2% CPU usage AFAIK

Expected Results:  
w/ events disabled it jumps bw ~0.30% - ~0.17% (cpu usage) no meter if I move mouse or print something

IDK, it can affect cpu bound games, laptop batteries, etc.
LESS FPS PEOPLE, LESS F. F.P.S.
jk
Comment 1 Bug Bugs 2024-06-09 09:14:22 UTC
BTW
I guess "bugs" site people missed CONTEXT line for "Additional comments"

It not looks like "additional" now
Comment 2 Daniel Pielmeier gentoo-dev 2024-06-18 17:46:57 UTC
I have seen this commit and and apparently I did not read properly. So I thought it might not be relevant for most users. I see your point now. Unfortunately I am quite busy at the moment so it might take some time. I appreciate your patience.
Comment 3 Larry the Git Cow gentoo-dev 2024-06-27 19:20:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=16213d4982baa4cc111d7138deacd789554dbfe2

commit 16213d4982baa4cc111d7138deacd789554dbfe2
Author:     Daniel Pielmeier <billie@gentoo.org>
AuthorDate: 2024-06-27 19:19:23 +0000
Commit:     Daniel Pielmeier <billie@gentoo.org>
CommitDate: 2024-06-27 19:19:23 +0000

    app-admin/conky: add 1.21.3
    
    Closes: https://bugs.gentoo.org/933864
    Signed-off-by: Daniel Pielmeier <billie@gentoo.org>

 app-admin/conky/Manifest            |   1 +
 app-admin/conky/conky-1.21.3.ebuild | 251 ++++++++++++++++++++++++++++++++++++
 app-admin/conky/metadata.xml        |   2 +
 3 files changed, 254 insertions(+)