Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 933775 - dev-util/spirv-llvm-translator-{15.0.0-r1,16.0.0-r1,17.0.0-r2} fail tests on x86
Summary: dev-util/spirv-llvm-translator-{15.0.0-r1,16.0.0-r1,17.0.0-r2} fail tests on x86
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: x86 Linux
: Normal normal
Assignee: Conrad Kostecki
URL: https://github.com/KhronosGroup/SPIRV...
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2024-06-07 20:27 UTC by matoro
Modified: 2024-06-08 20:49 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log and emerge --info (15.0.0-r1) (file_933775.txt,129.83 KB, text/plain)
2024-06-07 20:28 UTC, matoro
Details
build.log and emerge --info (16.0.0-r1) (file_933775.txt,184.27 KB, text/plain)
2024-06-07 20:28 UTC, matoro
Details
build.log and emerge --info (17.0.0-r2) (file_933775.txt,205.70 KB, text/plain)
2024-06-07 20:29 UTC, matoro
Details

Note You need to log in before you can comment on or make changes to this bug.
Description matoro archtester 2024-06-07 20:27:32 UTC
All 3 of these requested versions fail on x86, around debug-related stuff.  Does not fail on amd64.

15.0.0-r1:
********************
Failed Tests (9):
  LLVM_SPIRV :: DebugInfo/X86/dbg-declare-alloca.ll
  LLVM_SPIRV :: DebugInfo/X86/dbg-declare-arg.ll
  LLVM_SPIRV :: DebugInfo/X86/dbg-value-const-byref.ll
  LLVM_SPIRV :: DebugInfo/X86/dw_op_minus_direct.ll
  LLVM_SPIRV :: DebugInfo/X86/dwarf-aranges-no-dwarf-labels.ll
  LLVM_SPIRV :: DebugInfo/X86/frame-register.ll
  LLVM_SPIRV :: DebugInfo/X86/this-stack_value.ll
  LLVM_SPIRV :: GroupAndSubgroupInstructions.spvasm
  LLVM_SPIRV :: spirv-tools-dis.ll
 
Testing Time: 7.10s
  Unsupported      :   1
  Passed           : 628
  Expectedly Failed:   5
  Failed           :   9

16.0.0-r1:
********************
Failed Tests (9):
  LLVM_SPIRV :: DebugInfo/X86/dbg-declare-alloca.ll
  LLVM_SPIRV :: DebugInfo/X86/dbg-declare-arg.ll
  LLVM_SPIRV :: DebugInfo/X86/dbg-value-const-byref.ll
  LLVM_SPIRV :: DebugInfo/X86/dw_op_minus_direct.ll
  LLVM_SPIRV :: DebugInfo/X86/dwarf-aranges-no-dwarf-labels.ll
  LLVM_SPIRV :: DebugInfo/X86/frame-register.ll
  LLVM_SPIRV :: DebugInfo/X86/this-stack_value.ll
  LLVM_SPIRV :: GroupAndSubgroupInstructions.spvasm
  LLVM_SPIRV :: spirv-tools-dis.ll
 
Testing Time: 8.34s
  Unsupported      :   1
  Passed           : 657
  Expectedly Failed:   3
  Failed           :   9

17.0.0-r2:
********************
Failed Tests (7):
  LLVM_SPIRV :: DebugInfo/X86/dbg-declare-alloca.ll
  LLVM_SPIRV :: DebugInfo/X86/dbg-declare-arg.ll
  LLVM_SPIRV :: DebugInfo/X86/dbg-value-const-byref.ll
  LLVM_SPIRV :: DebugInfo/X86/dw_op_minus_direct.ll
  LLVM_SPIRV :: DebugInfo/X86/dwarf-aranges-no-dwarf-labels.ll
  LLVM_SPIRV :: DebugInfo/X86/frame-register.ll
  LLVM_SPIRV :: DebugInfo/X86/this-stack_value.ll
 
Testing Time: 8.61s
  Unsupported      :   1
  Passed           : 696
  Expectedly Failed:   4
  Failed           :   7
Comment 1 matoro archtester 2024-06-07 20:28:20 UTC
Created attachment 895363 [details]
build.log and emerge --info (15.0.0-r1)
Comment 2 matoro archtester 2024-06-07 20:28:41 UTC
Created attachment 895364 [details]
build.log and emerge --info (16.0.0-r1)
Comment 3 matoro archtester 2024-06-07 20:29:08 UTC
Created attachment 895365 [details]
build.log and emerge --info (17.0.0-r2)
Comment 4 Matt Turner gentoo-dev 2024-06-07 20:34:43 UTC
I think it's likely intractable to make the tests pass on all platforms, but $URL is a PR I made to fix the test expectations on x86.

I haven't gotten back to it to fix it up so that the expectations are conditional based on the platform.
Comment 5 Matt Turner gentoo-dev 2024-06-07 21:35:38 UTC
I've updated the upstream PR.
Comment 6 Larry the Git Cow gentoo-dev 2024-06-07 21:59:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c63dfeafaa5062f90b4dde3c335acd4df03c5dc4

commit c63dfeafaa5062f90b4dde3c335acd4df03c5dc4
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2024-06-07 21:59:17 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2024-06-07 21:59:28 +0000

    dev-util/spirv-llvm-translator: Fix some tests
    
    Closes: https://bugs.gentoo.org/933775
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 dev-util/spirv-llvm-translator/spirv-llvm-translator-15.0.0-r1.ebuild | 3 +++
 dev-util/spirv-llvm-translator/spirv-llvm-translator-16.0.0-r1.ebuild | 3 +++
 dev-util/spirv-llvm-translator/spirv-llvm-translator-17.0.0-r2.ebuild | 3 +++
 dev-util/spirv-llvm-translator/spirv-llvm-translator-18.1.0.ebuild    | 3 +++
 4 files changed, 12 insertions(+)
Comment 7 Matt Turner gentoo-dev 2024-06-07 22:00:14 UTC
With the commit in comment #6, the tests passed for me in v17 and v18. Please give it a try.
Comment 8 matoro archtester 2024-06-08 17:23:51 UTC
This indeed fixes the debug ones.  What do you want to do about the remaining items on 15 and 16?

15.0.0-r1:
********************
Failed Tests (2):
  LLVM_SPIRV :: GroupAndSubgroupInstructions.spvasm
  LLVM_SPIRV :: spirv-tools-dis.ll


Testing Time: 7.07s
  Unsupported      :   1
  Passed           : 635
  Expectedly Failed:   5
  Failed           :   2

16.0.0-r1:
********************
Failed Tests (2):
  LLVM_SPIRV :: GroupAndSubgroupInstructions.spvasm
  LLVM_SPIRV :: spirv-tools-dis.ll


Testing Time: 8.58s
  Unsupported      :   1
  Passed           : 664
  Expectedly Failed:   3
  Failed           :   2
Comment 9 Matt Turner gentoo-dev 2024-06-08 20:49:16 UTC
I don't know of any good reasons to use llvm < 17 at this point, so probably let's just forget about those versions. I'll update the stabilization bug.