Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 933542 - gui-libs/wlroots-0.17.3-r1 - [libliftoff-0.5.0] ../.../libliftoff.c: error: too few arguments to function liftoff_output_apply
Summary: gui-libs/wlroots-0.17.3-r1 - [libliftoff-0.5.0] ../.../libliftoff.c: error: t...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Arthur Zamarin
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-06-04 18:21 UTC by Toralf Förster
Modified: 2024-06-05 09:25 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,18.21 KB, text/plain)
2024-06-04 18:21 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,84.37 KB, text/plain)
2024-06-04 18:21 UTC, Toralf Förster
Details
environment (environment,117.70 KB, text/plain)
2024-06-04 18:21 UTC, Toralf Förster
Details
etc.clang.tar.xz (etc.clang.tar.xz,1.20 KB, application/x-xz)
2024-06-04 18:21 UTC, Toralf Förster
Details
etc.portage.tar.xz (etc.portage.tar.xz,30.07 KB, application/x-xz)
2024-06-04 18:21 UTC, Toralf Förster
Details
gui-libs:wlroots-0.17.3-r1:20240604-180811.log (gui-libs:wlroots-0.17.3-r1:20240604-180811.log,102.41 KB, text/plain)
2024-06-04 18:21 UTC, Toralf Förster
Details
qlist-info.txt (qlist-info.txt,178.87 KB, text/plain)
2024-06-04 18:21 UTC, Toralf Förster
Details
temp.tar.xz (temp.tar.xz,26.63 KB, application/x-xz)
2024-06-04 18:21 UTC, Toralf Förster
Details
adds limiters to package discovery (wlroots-0.17.3-limit-libliftoff.patch,436 bytes, patch)
2024-06-05 07:35 UTC, NHO
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2024-06-04 18:21:30 UTC
too long lines were shrinked:

[171/340] x86_64-pc-linux-gnu-gcc -Ilibwlroots.so.12.p -I. -I../wlroots-0.17.3 -Iinclude -I../wlroots-0.17.3/include -Iprotocol -Irender/gles2/shaders -Ibackend/drm -I/usr/lib64/libffi/include -I/usr/include/libdrm -I/usr/include/pixman-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winv
[172/340] x86_64-pc-linux-gnu-gcc -Ilibwlroots.so.12.p -I. -I../wlroots-0.17.3 -Iinclude -I../wlroots-0.17.3/include -Iprotocol -Irender/gles2/shaders -Ibackend/drm -I/usr/lib64/libffi/include -I/usr/include/libdrm -I/usr/include/pixman-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winv
[173/340] x86_64-pc-linux-gnu-gcc -Ilibwlroots.so.12.p -I. -I../wlroots-0.17.3 -Iinclude -I../wlroots-0.17.3/include -Iprotocol -Irender/gles2/shaders -Ibackend/drm -I/usr/lib64/libffi/include -I/usr/include/libdrm -I/usr/include/pixman-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winv
FAILED: libwlroots.so.12.p/backend_drm_libliftoff.c.o 
x86_64-pc-linux-gnu-gcc -Ilibwlroots.so.12.p -I. -I../wlroots-0.17.3 -Iinclude -I../wlroots-0.17.3/include -Iprotocol -Irender/gles2/shaders -Ibackend/drm -I/usr/lib64/libffi/include -I/usr/include/libdrm -I/usr/include/pixman-1 -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -
../wlroots-0.17.3/backend/drm/libliftoff.c: In function crtc_commit:
../wlroots-0.17.3/backend/drm/libliftoff.c:439:19: error: too few arguments to function liftoff_output_apply
  439 |         int ret = liftoff_output_apply(crtc->liftoff, req, flags);
      |                   ^~~~~~~~~~~~~~~~~~~~

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 23.0_systemd-20240602-172254

  UNMASKED:
  ~dev-libs/icu-75.1
  ~dev-libs/icu-layoutex-75.1

  The attached etc.portage.tar.xz has all details.
  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-14 *
clang/llvm (if any):
clang version 18.1.6
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/18/bin
Configuration file: /etc/clang/x86_64-pc-linux-gnu-clang.cfg
/usr/lib/llvm/18
18.1.6
Python 3.12.3
Available Ruby profiles:
  [1]   ruby31 (with Rubygems)
  [2]   ruby32 (with Rubygems)
  [3]   ruby33 (with Rubygems) *
Available Rust versions:
  [1]   rust-bin-1.78.0 *
The following VMs are available for generation-2:
1)	Eclipse Temurin JDK 17.0.11_p9 [openjdk-bin-17]
*)	Eclipse Temurin JDK 21.0.3_p9 [openjdk-bin-21]
Available Java Virtual Machines:
  [1]   openjdk-bin-17 
  [2]   openjdk-bin-21  system-vm

The Glorious Glasgow Haskell Compilation System, version 9.2.8
php cli (if any):
go version go1.22.3 linux/amd64

  HEAD of ::gentoo
commit 4b75397d33ee8e117b7b51ebb64b2d3cb6abe98c
Author: Repository mirror & CI <repomirrorci@gentoo.org>
Date:   Tue Jun 4 17:04:04 2024 +0000

    2024-06-04 17:04:03 UTC

emerge -qpvO gui-libs/wlroots
[ebuild  N    ] gui-libs/wlroots-0.17.3-r1  USE="X drm libinput liftoff session tinywl x11-backend -vulkan -xcb-errors"
Comment 1 Toralf Förster gentoo-dev 2024-06-04 18:21:31 UTC
Created attachment 895074 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2024-06-04 18:21:32 UTC
Created attachment 895075 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2024-06-04 18:21:34 UTC
Created attachment 895076 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2024-06-04 18:21:34 UTC
Created attachment 895077 [details]
etc.clang.tar.xz
Comment 5 Toralf Förster gentoo-dev 2024-06-04 18:21:36 UTC
Created attachment 895078 [details]
etc.portage.tar.xz
Comment 6 Toralf Förster gentoo-dev 2024-06-04 18:21:41 UTC
Created attachment 895079 [details]
gui-libs:wlroots-0.17.3-r1:20240604-180811.log
Comment 7 Toralf Förster gentoo-dev 2024-06-04 18:21:44 UTC
Created attachment 895080 [details]
qlist-info.txt
Comment 8 Toralf Förster gentoo-dev 2024-06-04 18:21:47 UTC
Created attachment 895081 [details]
temp.tar.xz
Comment 9 Larry the Git Cow gentoo-dev 2024-06-04 18:31:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d1528c7f6bbfe7b29cdff23d7fe221d6c5e89b36

commit d1528c7f6bbfe7b29cdff23d7fe221d6c5e89b36
Author:     Leonardo Hernández Hernández <leohdz172@proton.me>
AuthorDate: 2024-06-01 05:22:25 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2024-06-04 18:31:29 +0000

    gui-libs/wlroots: add upper bound in libliftoff dep
    
    Closes: https://bugs.gentoo.org/933542
    Signed-off-by: Leonardo Hernández Hernández <leohdz172@proton.me>
    Closes: https://github.com/gentoo/gentoo/pull/36979
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 gui-libs/wlroots/wlroots-0.17.3-r2.ebuild | 109 ++++++++++++++++++++++++++++++
 1 file changed, 109 insertions(+)
Comment 10 NHO 2024-06-05 07:19:50 UTC
Fails for me with new version, I have USE=-liftoff so upper bound doesn't apply.
Comment 12 NHO 2024-06-05 07:35:55 UTC
Created attachment 895110 [details, diff]
adds limiters to package discovery

This patch pushes same exact fix to build system, so it would also ignore libliftoff-0.5.0 instead of locating libliftoff and trying to build with it.
Comment 13 Alfred Wingate 2024-06-05 09:00:30 UTC
Does the libliftoff use flag even do anything?

I dont see hits hooked up to anything, is this just an unhandled automagic dependency?
Comment 14 NHO 2024-06-05 09:06:20 UTC
Yeah, it looks like it's unhanded automatic dependency.
There doesn't appear to be a way to pass USE=liftoff to underlying meson without more patching.