https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: app-admin/hardinfo2-2.1.11 overwrites CFLAGS/CXXFLAGS or adds uncommon ones. Discovered on: amd64 (internal ref: guru_ci) Info about the issue: https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#QA0069
Created attachment 894650 [details] build.log build log and emerge --info
Can we make an exception for this? The developer insists optimization flags should be turned off just for compiling these parts of the code as defined here in CMakeLists.txt:313-320 set_source_files_properties( modules/benchmark/blowfish.c modules/benchmark/fftbench.c modules/benchmark/md5.c modules/benchmark/sha1.c PROPERTIES COMPILE_FLAGS "-O0 -Wall -Wextra -Werror=implicit-function-declaration" ) The developer states the reason in modules/benchmark/md5.c:34-36 and in modules/benchmark/sha1.c:36-38 #if defined(__OPTIMIZE__) #error You must compile this program without "-O". (Or else the benchmark results may be different!) #endif which will cause the program to not compile if optimizations are turned on for this part of the code. I can just remove those 3 lines of code from both modules/benchmark/md5.c and modules/benchmark/sha1.c, and remove the -O0 flag from CMakeLists.txt and it will compile just fine but benchmark results may be different as the developer states.
guru_ci has reproduced this issue with version 2.1.11-r1 - Updating summary.
guru_ci has reproduced this issue with version 2.1.14 - Updating summary.
guru_ci has reproduced this issue with version 2.1.17 - Updating summary.
guru_ci has reproduced this issue with version 2.2.1 - Updating summary.
guru_ci has reproduced this issue with version 2.2.4 - Updating summary.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=019e8b6181b183fd812117b3029591ae88661528 commit 019e8b6181b183fd812117b3029591ae88661528 Author: Quincy Fleming <quincyf467@protonmail.com> AuthorDate: 2024-11-27 11:30:10 +0000 Commit: Quincy Fleming <quincyf467@protonmail.com> CommitDate: 2024-11-27 11:30:10 +0000 app-admin/hardinfo2: drop 2.2.4-r0 Closes: https://bugs.gentoo.org/933186 Signed-off-by: Quincy Fleming <quincyf467@protonmail.com> app-admin/hardinfo2/hardinfo2-2.2.4.ebuild | 60 ------------------------------ 1 file changed, 60 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=484deb3ab9e3e1014c54f872735611a9a2d09009 commit 484deb3ab9e3e1014c54f872735611a9a2d09009 Author: Quincy Fleming <quincyf467@protonmail.com> AuthorDate: 2024-11-27 11:29:18 +0000 Commit: Quincy Fleming <quincyf467@protonmail.com> CommitDate: 2024-11-27 11:29:18 +0000 app-admin/hardinfo2: Fix overwriting CFLAGS Bug: https://bugs.gentoo.org/933186 Signed-off-by: Quincy Fleming <quincyf467@protonmail.com> app-admin/hardinfo2/hardinfo2-2.2.4-r1.ebuild | 62 +++++++++++++++++++++++++++ 1 file changed, 62 insertions(+)
