Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 933086 - sys-auth/oath-toolkit-2.6.11 - global.c:164:3: error: implicit declaration of function 'free'
Summary: sys-auth/oath-toolkit-2.6.11 - global.c:164:3: error: implicit declaration of...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Robin Johnson
URL:
Whiteboard: fixed in 2.6.11
Keywords:
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2024-05-28 19:08 UTC by ktoupt
Modified: 2024-11-01 16:07 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,281.86 KB, text/x-log)
2024-05-28 19:08 UTC, ktoupt
Details
emerge --info (info.txt,7.20 KB, text/plain)
2024-05-28 19:09 UTC, ktoupt
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ktoupt 2024-05-28 19:08:34 UTC
Created attachment 894572 [details]
build.log

[ebuild  N    ] sys-auth/oath-toolkit-2.6.11  USE="pam -static-libs -test"

This is probably because of GCC 14, so it should probably block on c99-porting?

Patch:

diff --git a/libpskc/global.c b/libpskc/global.c
index 1a51450..a01ec08 100644
--- a/libpskc/global.c
+++ b/libpskc/global.c
@@ -21,6 +21,8 @@
 
 #include <config.h>
 
+#include <stdlib.h>
+
 #include <pskc/pskc.h>
 
 #include "internal.h"
Comment 1 ktoupt 2024-05-28 19:09:01 UTC
Created attachment 894573 [details]
emerge --info
Comment 2 Michael Orlitzky gentoo-dev 2024-08-31 11:07:08 UTC
It's actually a "musl issue" because glibc includes that header incidentally. Upstream already has a patch. I have a musl system now so I'll just fix it.
Comment 3 Larry the Git Cow gentoo-dev 2024-08-31 13:18:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6cd7e5165b7750317d42a65b9bc20ce65eec8302

commit 6cd7e5165b7750317d42a65b9bc20ce65eec8302
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2024-08-31 11:03:45 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2024-08-31 13:18:30 +0000

    sys-auth/oath-toolkit: fix the build on musl
    
    Add an upstream patch to fix the build on musl, and then fix a new
    problem introduced by the patch: the build system is extremely sensitive
    to mtime changes in the source tree, in that patching triggers a
    rebuild of some Makefile sources, which ultimately tries to invoke
    automake. We have to fudge the mtime on the patched file to avoid this.
    
    Bug: https://bugs.gentoo.org/936309
    Closes: https://bugs.gentoo.org/933086
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 .../files/oath-toolkit-2.6.11-fix-musl-build.patch | 24 ++++++++++++++++++++++
 sys-auth/oath-toolkit/oath-toolkit-2.6.11.ebuild   | 12 +++++++++++
 2 files changed, 36 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2024-11-01 16:07:19 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4d76a1b7a997ae622f01909593eb808ccfb8edfb

commit 4d76a1b7a997ae622f01909593eb808ccfb8edfb
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2024-11-01 16:06:24 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2024-11-01 16:07:07 +0000

    sys-auth/oath-toolkit: drop 2.6.9
    
    Bug: https://bugs.gentoo.org/933086
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 sys-auth/oath-toolkit/Manifest                     |  1 -
 ...build-failure-noticed-on-ArchLinux-xmlsec.patch | 40 -------------
 sys-auth/oath-toolkit/oath-toolkit-2.6.9.ebuild    | 70 ----------------------
 3 files changed, 111 deletions(-)