Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 932155 - FindHIP breaks rocFFT build on Prefix
Summary: FindHIP breaks rocFFT build on Prefix
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Sam James
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-18 13:34 UTC by Benda Xu
Modified: 2024-05-18 13:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benda Xu gentoo-dev 2024-05-18 13:34:04 UTC
hip::host and hip::device is only defined in hip-config.cmake.  Keeping FindHIP introduces cmake bugs that are difficult to trace.

For example, rocFFT in Prefix does not include the correct hip-config.cmake but is confused by FindHIP.cmake.

Dropping FindHIP was a serious consideration after the endless debugging of the nondeterministic behaviors caused by having both hip-config and FindHIP.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5223e983a0810e46633362ff4dbad6a194208819

I suggest the way forward is to understand the function of hip_add_executable() cmake function, patch torch/roctracer or provide it in hip-config.cmake.

Reproducible: Always
Comment 1 Benda Xu gentoo-dev 2024-05-18 13:45:29 UTC
I could build roctracer-5.7.1-r1 with hip-5.7.1-r1 (without FindHIP.cmake).

roctracer is no longer a blocker.  FindHIP is only for torch.  It is torch that should be fixed.