Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 931944 - dev-db/postgresql-{12.19,13.15,14.12,15.7,16.3}-r1: ebuilds are missing LLVM_OPTIONAL
Summary: dev-db/postgresql-{12.19,13.15,14.12,15.7,16.3}-r1: ebuilds are missing LLVM_...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: PgSQL Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-15 10:49 UTC by Matt Whitlock
Modified: 2024-05-15 17:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Whitlock 2024-05-15 10:49:20 UTC
The dev-db/postgresql ebuilds were recently updated to use llvm-r1.eclass instead of llvm.eclass. This causes them to require an enabled LLVM_SLOT even when USE="-llvm". This should not be necessary since LLVM is an optional dependency. llvm-r1.eclass supports an LLVM_OPTIONAL variable that may be set in the ebuild (pre-inherit) to allow making the REQUIRED_USE on an llvm_slot_* flag conditional.

Please make use of LLVM_OPTIONAL in the dev-db/postgresql ebuilds, as follows:

LLVM_OPTIONAL=1
⋮
inherit llvm-r1
⋮
REQUIRED_USE="llvm? ( ${LLVM_REQUIRED_USE} )"
Comment 1 Larry the Git Cow gentoo-dev 2024-05-15 12:48:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2cfd7751bb799b83372e718a4992f4d4ea7435be

commit 2cfd7751bb799b83372e718a4992f4d4ea7435be
Author:     Patrick Lauer <patrick@gentoo.org>
AuthorDate: 2024-05-15 12:47:23 +0000
Commit:     Patrick Lauer <patrick@gentoo.org>
CommitDate: 2024-05-15 12:48:08 +0000

    dev-db/postgresql: Fix llvm slot behaviour
    
    Closes: https://bugs.gentoo.org/931944
    Signed-off-by: Patrick Lauer <patrick@gentoo.org>

 .../{postgresql-12.19-r1.ebuild => postgresql-12.19-r2.ebuild}           | 1 +
 .../{postgresql-13.15-r1.ebuild => postgresql-13.15-r2.ebuild}           | 1 +
 .../{postgresql-14.12-r1.ebuild => postgresql-14.12-r2.ebuild}           | 1 +
 .../postgresql/{postgresql-15.7-r1.ebuild => postgresql-15.7-r2.ebuild}  | 1 +
 .../postgresql/{postgresql-16.3-r1.ebuild => postgresql-16.3-r2.ebuild}  | 1 +
 5 files changed, 5 insertions(+)
Comment 2 Matt Whitlock 2024-05-15 17:36:44 UTC
Oops: did you miss the second part of the fix? I see that you added LLVM_OPTIONAL=1, but I don't see any conditional ${LLVM_REQUIRED_USE} in REQUIRED_USE. I don't think llvm-r1.eclass will automatically add that when LLVM_OPTIONAL is set, as it doesn't know which USE flag to predicate upon. Without that, you now will not be requiring that some LLVM_SLOT is set when USE="llvm" is set.