Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 931864 - app-emulation/virt-manager GUI requires dbus[X] when it shouldn't
Summary: app-emulation/virt-manager GUI requires dbus[X] when it shouldn't
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Virtualization Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-13 11:01 UTC by Jason Gantner
Modified: 2025-01-06 04:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Gantner 2024-05-13 11:01:50 UTC
The ebuilds for app-emulation/virt-manager list dubs[X] as required when the gui use flag is activated.

From my (short) investigation, dbus[X] only enables autolaunch of dbus when X is started. If this is the case, the dependency should be dbus regardless of the state of the X use flag.

I tested an ebuild modified accordingly and can confirm that everything builds and works as intended on my system (x86-64/no-multilib) where the X flag is disabled globally, only Wayland is available (through sway), and dbus is built without the X flag.
Comment 1 Filip Kobierski 2024-12-27 10:55:34 UTC
I have also tested this and it works fine with -X.
Comment 2 Larry the Git Cow gentoo-dev 2025-01-06 03:35:46 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0d9516f643e9e4b5681400643285d2076d30b038

commit 0d9516f643e9e4b5681400643285d2076d30b038
Author:     Filip Kobierski <fkobi@pm.me>
AuthorDate: 2024-12-06 18:54:27 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2025-01-06 03:33:48 +0000

    app-emulation/virt-manager: add 5.0.0-r1 with improvements
    
    - add verify-sig USE flag
    - dependency changes:
      - RDEPEND: do not require dbus[X]
      - BDEPEND: add sys-devel/gettext
      - allow gtksourceview:[34]
      - update versions
    - src_configure:
      - disable unavailable hypervisors
      - sort emesonargs in upstream's order
    - variable changes
      - add DESIGN.md to DOCS
      - update LICENSE
    - optfeatures
      - add libguestfs' VM inspection
      - improve QEMU description
    - misc
      - sort & tidy src_install rm commands
      - improve QEMU optfeature description
      - add useful link to a specification file, which many of the chages
        here are based on
      - break too long lines
    
    verify-sig ports modeled after net-libs/miniupnp & mgorny's article
    
    Bug: https://bugs.gentoo.org/931864
    Signed-off-by: Filip Kobierski <fkobi@pm.me>
    Closes: https://github.com/gentoo/gentoo/pull/39545
    Signed-off-by: Sam James <sam@gentoo.org>

 app-emulation/virt-manager/Manifest                |   1 +
 .../virt-manager/virt-manager-5.0.0-r1.ebuild      | 108 +++++++++++++++++++++
 2 files changed, 109 insertions(+)