Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 931777 - gui-libs/wlroots: USE=drm wrongly masked on ppc64le
Summary: gui-libs/wlroots: USE=drm wrongly masked on ppc64le
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Profiles (show other bugs)
Hardware: PPC64 Linux
: Normal normal
Assignee: Arthur Zamarin
URL:
Whiteboard:
Keywords:
Depends on: 926099
Blocks:
  Show dependency tree
 
Reported: 2024-05-12 03:18 UTC by Red
Modified: 2024-06-12 02:10 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Red 2024-05-12 03:18:24 UTC
I did my usual system update and reboot. When I try to start sway after, I got a `cannot create DRM backend, disabled at compile time` error preventing sway from starting. Looking into it, I see:

```
/var/db/repos/gentoo/profiles/arch/base/package.use.mask
# Leonardo Hernández Hernández <leohdz172@proton.me> (2023-11-25)
# media-libs/libdisplay-info (drm) and dev-libs/libliftoff (liftoff)
# are only available for amd64, arm64 and riscv
>=gui-libs/wlroots-0.17.0 drm liftoff
```

First I noticed no attached bug (and after a brief search I can't find one here). Second, on ppc64le, not only does libdisplay-info *work*, it's even unmasked... So I'm not sure why ppc64le was excluded in that list.

I don't understand this global mask in the first place tbh, any info why this is needed would be appreciated. Anyways I cannot test big endian or 32bit this second as those chroots needs a profile update and -e @world (fun), and I can't speak for liftoff, as wlroots with USE="liftoff -drm" still couldn't do anything.

Also, is masking drm needed even if it didn't work? Either sway won't launch because it's missing drm, or because drm won't work :P I am not aware of wlroots being able to render to the framebuffer in any other way, so is the other usecase here using wlroots nested inside of X11?
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-05-12 03:28:09 UTC
It's pretty standard when something gains a new dep and isn't yet keyworded. It involvd a judgement all as to whether it's worth asking for kwing there / likely to be used.

Anyway, the kwing did get done in bug 926099 so we can drop it now.

> Also, is masking drm needed even if it didn't work? Either sway won't launch because it's missing drm

I think the real question is: is USE=drm actually useful on wlroots or should it be mandatory?
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-05-12 03:30:39 UTC
(In reply to Sam James from comment #1)
> It's pretty standard when something gains a new dep and isn't yet keyworded.
> It involvd a judgement all as to whether it's worth asking for kwing there /
> likely to be used.
> 
> Anyway, the kwing did get done in bug 926099 so we can drop it now.
> 

(You should generally look at the repo state _when it got added_, not later, as that's just about whether it's stale, not wrong to do to begin with.)

> > Also, is masking drm needed even if it didn't work? Either sway won't launch because it's missing drm
> 
> I think the real question is: is USE=drm actually useful on wlroots or
> should it be mandatory?
Comment 3 Red 2024-05-12 03:37:03 UTC
Thanks, and sorry sam, that's a good point-- I'll make sure to look at the repo history next time.

And I'm not an expert but yeah from my knowledge, wlroots with USE=-drm seems without many/any uses (not that the option is a bad thing!!)
Comment 4 Daniella Kicsak 2024-06-11 04:01:21 UTC
(In reply to Sam James from comment #1)
> It's pretty standard when something gains a new dep and isn't yet keyworded.
> It involvd a judgement all as to whether it's worth asking for kwing there /
> likely to be used.
> 
> Anyway, the kwing did get done in bug 926099 so we can drop it now.
> 
> > Also, is masking drm needed even if it didn't work? Either sway won't launch because it's missing drm
> 
> I think the real question is: is USE=drm actually useful on wlroots or
> should it be mandatory?

The use flag seems to enable/disable some important includes. I'm not on sway but instead labwc. I noticed that lab won't compile because it's missing wlr_drm_lease_v1.h. For me at least, having it keyworded breaks functionality.
Comment 5 Larry the Git Cow gentoo-dev 2024-06-12 02:10:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=949c058db2f2444484cabd7e434ac905ff7982c4

commit 949c058db2f2444484cabd7e434ac905ff7982c4
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-06-12 02:10:00 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-06-12 02:10:00 +0000

    profiles/arch: cleanup wlroots masks
    
    Move into package.use.stable.mask for ppc64+x86 now that it's keyworded
    there. Cleanup the other masks.
    
    Closes: https://bugs.gentoo.org/931777
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/arch/amd64/package.use.mask                | 5 -----
 profiles/arch/arm64/package.use.mask                | 5 -----
 profiles/arch/base/package.use.mask                 | 5 -----
 profiles/arch/powerpc/ppc64/package.use.stable.mask | 4 ++++
 profiles/arch/riscv/package.use.mask                | 5 -----
 profiles/arch/x86/package.use.stable.mask           | 4 ++++
 6 files changed, 8 insertions(+), 20 deletions(-)