Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 931607 - app-emulation/hercules-sdl-4.7.0 has implicit function declarations in configure logs
Summary: app-emulation/hercules-sdl-4.7.0 has implicit function declarations in config...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: matoro
URL: https://github.com/SDL-Hercules-390/h...
Whiteboard:
Keywords: PullRequest, UPSTREAM
Depends on:
Blocks: implicit-in-configure
  Show dependency tree
 
Reported: 2024-05-09 06:32 UTC by Agostino Sarubbo
Modified: 2024-06-06 20:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,509.65 KB, text/plain)
2024-05-09 06:32 UTC, Agostino Sarubbo 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-05-09 06:32:49 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-emulation/hercules-sdl-4.7.0 has implicit function declarations in configure logs.
Discovered on: amd64 (internal ref: ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#QA0072
Comment 1 Agostino Sarubbo gentoo-dev 2024-05-09 06:32:50 UTC 
Created attachment 892547 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-05-09 06:32:52 UTC 
Found the following implicit function declarations in configure logs:

config.log:8771 - memset
config.log:8781 - strlen
config.log:9440 - getopt
Comment 3 matoro archtester 2024-05-09 16:44:09 UTC 
Opened https://github.com/SDL-Hercules-390/hyperion/pull/658 upstream
Comment 4 Larry the Git Cow gentoo-dev 2024-06-06 20:11:10 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=05552928a36bec9151483f7140e2fc4ee7b94594

commit 05552928a36bec9151483f7140e2fc4ee7b94594
Author:     Matoro Mahri <matoro_gentoo@matoro.tk>
AuthorDate: 2024-05-17 16:04:01 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2024-06-06 20:10:44 +0000

    app-emulation/hercules-sdl: fix modern-C99, file collision
    
    Touching just configure.ac is fine as we call eautoreconf in ebuild.
    
    See: https://github.com/SDL-Hercules-390/hyperion/pull/658
    Closes: https://bugs.gentoo.org/931607
    Closes: https://bugs.gentoo.org/931610
    Signed-off-by: Matoro Mahri <matoro_gentoo@matoro.tk>
    Closes: https://github.com/gentoo/gentoo/pull/36724
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 .../files/hercules-sdl-4.7.0-backport-pr658.patch  | 46 +++++++++++
 .../hercules-sdl/hercules-sdl-4.7.0-r1.ebuild      | 89 ++++++++++++++++++++++
 2 files changed, 135 insertions(+)