Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 931556 - app-crypt/libscrypt-1.22-r2 fails tests
Summary: app-crypt/libscrypt-1.22-r2 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on: 945078
Blocks: 915000
  Show dependency tree
 
Reported: 2024-05-08 07:03 UTC by Agostino Sarubbo
Modified: 2024-11-27 04:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,49.19 KB, text/plain)
2024-05-08 07:03 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-05-08 07:03:07 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: app-crypt/libscrypt-1.22-r2 fails tests.
Discovered on: amd64 (internal ref: gcc14_tinderbox)
System: GCC-14-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-14)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0015
Comment 1 Agostino Sarubbo gentoo-dev 2024-05-08 07:03:08 UTC
Created attachment 892469 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-05-08 07:03:09 UTC
Error(s) that match a know pattern:


TEST THREE: FAILED to match reference on hash
TEST ONE and a half: Successfully failed on error: Invalid argument
Comment 3 gen2dev 2024-11-24 16:54:45 UTC
This is an open issue upstream reported in 2023 by another distro
  https://github.com/technion/libscrypt/issues/60

It fails when file crypto_scrypt-nosse.c is compiled with clang 15 -O2 or gcc 13.2.1 -O3. With optimization to -Os/-O2, or with clang 14 or an earlier gcc and keeping -O3, it passes.

I verified that it still fails the same with gcc 14.2.1 -O3 and passes with -O2.
Comment 4 gen2dev 2024-11-24 17:02:58 UTC
(In reply to gen2dev from comment #3)
> This is an open issue upstream reported in 2023 by another distro
>   https://github.com/technion/libscrypt/issues/60
> 
> It fails when file crypto_scrypt-nosse.c is compiled with clang 15 -O2 or
> gcc 13.2.1 -O3. With optimization to -Os/-O2, or with clang 14 or an earlier
> gcc and keeping -O3, it passes.
> 
> I verified that it still fails the same with gcc 14.2.1 -O3 and passes with
> -O2.

Rereading the upstream, I got the clang optimization backward. They say it passes with clang -O2 and fails with -Os. Also passes with gcc 10.5.0 but fails with gcc 12.3.1.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-26 22:14:20 UTC
I'm reducing it.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-27 02:39:06 UTC
Reported to GCC at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117800.
Comment 7 Larry the Git Cow gentoo-dev 2024-11-27 04:07:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f5b51f75ae23b06b09c460871f738a779bbe3177

commit f5b51f75ae23b06b09c460871f738a779bbe3177
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-11-27 04:06:14 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-11-27 04:06:14 +0000

    app-crypt/libscrypt: fix aliasing violation
    
    Closes: https://bugs.gentoo.org/931556
    Signed-off-by: Sam James <sam@gentoo.org>

 .../libscrypt/files/libscrypt-1.22-aliasing.patch  | 309 +++++++++++++++++++++
 app-crypt/libscrypt/libscrypt-1.22-r3.ebuild       |  37 +++
 2 files changed, 346 insertions(+)