Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 931066 - sys-power/wluma-4.4.0: provide upstream systemd user file
Summary: sys-power/wluma-4.4.0: provide upstream systemd user file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal enhancement (vote)
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-01 23:43 UTC by Mathijs Saey
Modified: 2024-05-02 04:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch which adds the upstream user service (add-user-service.patch,603 bytes, patch)
2024-05-01 23:45 UTC, Mathijs Saey
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathijs Saey 2024-05-01 23:43:56 UTC
Upstream provides a systemd user service that is useful for those of us who use `systemctl --user` to manage our background services. It would be handy if the package installed this by default.

Reproducible: Always




I have patched the ebuild to include the systemd user service, which works fine on my system. I'll upload the patch with the submitted bug.
Comment 1 Mathijs Saey 2024-05-01 23:45:14 UTC
Created attachment 892114 [details, diff]
patch which adds the upstream user service
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-05-01 23:49:55 UTC
commit beba5c2c968e5041af0562ca25048fd2de559e4c
Author: Benjamin Neff <benjamin@coding4coffee.ch>
Date:   Wed Mar 20 04:06:21 2024 +0100

    sys-power/wluma: install systemd user service

    This allows to start wluma with systemd as described in the README.

    Signed-off-by: Benjamin Neff <benjamin@coding4coffee.ch>
    Closes: https://github.com/gentoo/gentoo/pull/35836
    Signed-off-by: Patrick McLean <chutzpah@gentoo.org>

That got merged the other day (later than March 20th). Let me know if there's more to be done
Comment 3 Mathijs Saey 2024-05-01 23:59:57 UTC
I missed that patch, thanks for pointing it out.

However, the patch only adds the service to the 4.3.0 ebuild, not to the 4.4.0 ebuild. It's probably worth adding it to 4.4.0 ebuild too, especially so that it is included in future updates too?
Comment 4 Larry the Git Cow gentoo-dev 2024-05-02 00:57:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d9f7e76ebe8cd7824f2c2b86a078cf5ea60a47f1

commit d9f7e76ebe8cd7824f2c2b86a078cf5ea60a47f1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-05-02 00:56:55 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-02 00:56:55 +0000

    sys-power/wluma: install systemd user unit for 4.4.0 too
    
    Closes: https://bugs.gentoo.org/931066
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-power/wluma/{wluma-4.4.0.ebuild => wluma-4.4.0-r1.ebuild} | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-05-02 04:38:29 UTC
(In reply to Mathijs Saey from comment #3)
> I missed that patch, thanks for pointing it out.
> 
> However, the patch only adds the service to the 4.3.0 ebuild, not to the
> 4.4.0 ebuild. It's probably worth adding it to 4.4.0 ebuild too, especially
> so that it is included in future updates too?

Quite right - it was a race between when the PR was created/applied vs what commit was based on. Fixed, thanks!