Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 931064 - app-admin/emacs-updater: should not re-binary-emerge packages that caused it to believe it should rebuild
Summary: app-admin/emacs-updater: should not re-binary-emerge packages that caused it ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: GNU Emacs project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-01 21:23 UTC by Arsen Arsenović
Modified: 2024-05-02 16:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
[PATCH] emacs-updater: Pass --usepkg=n to Portage (0001-emacs-updater-Pass-usepkg-n-to-Portage.patch,1.17 KB, patch)
2024-05-01 21:23 UTC, Arsen Arsenović
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arsen Arsenović gentoo-dev 2024-05-01 21:23:24 UTC
Created attachment 892113 [details, diff]
[PATCH] emacs-updater: Pass --usepkg=n to Portage

Currently, emacs-updater will, when re-emerging, run emerge without specifying --usepkg.  This can lead to --usepkg in EMERGE_DEFAULT_OPTS causing emacs-updater to re-emerge packages it believes are out of date anyway.

This isn't very useful.

Normally, we'd trust the user, but I believe that all users would agree that this behavior is not useful (at least not in the 99% case), given that the purpose of *-updater style packages is to rebuild out-of-date packages.

--getbinpkg is omitted as it is the job of the binhost builder to maintain that the packages they distribute are compatible (IMO).
--usepkgonly is omitted as, in the case the user does indeed want only to use binaries, they should see that we're trying to rebuild.

I've attached a proposed patch.
Comment 1 Larry the Git Cow gentoo-dev 2024-05-02 16:52:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fc5d725ae78024a96b2ef780d769fb41e9977ed6

commit fc5d725ae78024a96b2ef780d769fb41e9977ed6
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2024-05-02 16:49:54 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2024-05-02 16:49:54 +0000

    app-admin/emacs-updater: add 1.18
    
    Closes: https://bugs.gentoo.org/931064
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-admin/emacs-updater/Manifest                  |  1 +
 app-admin/emacs-updater/emacs-updater-1.18.ebuild | 37 +++++++++++++++++++++++
 2 files changed, 38 insertions(+)