Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 930470 - [guru] gui-libs/gtk-session-lock-0.2.0-r3 fails tests: 1 Tests not enabled FAIL 0.02s exit status 1
Summary: [guru] gui-libs/gtk-session-lock-0.2.0-r3 fails tests: 1 Tests not enabled FA...
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gonçalo Negrier Duarte
URL:
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks:
 
Reported: 2024-04-23 06:51 UTC by Agostino Sarubbo
Modified: 2024-04-23 10:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,70.73 KB, text/plain)
2024-04-23 06:51 UTC, Agostino Sarubbo
Details
1-testlog.txt (1-testlog.txt,1012 bytes, text/plain)
2024-04-23 06:51 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-04-23 06:51:52 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: gui-libs/gtk-session-lock-0.2.0-r3 fails tests.
Discovered on: amd64 (internal ref: guru_ci)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0015
Comment 1 Agostino Sarubbo gentoo-dev 2024-04-23 06:51:53 UTC
Created attachment 891427 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-04-23 06:51:54 UTC
Created attachment 891428 [details]
1-testlog.txt

1-testlog.txt
Comment 3 Agostino Sarubbo gentoo-dev 2024-04-23 06:51:54 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


1/1 Tests not enabled        FAIL            0.02s   exit status 1
1/1 Tests not enabled FAIL            0.02s   exit status 1
Comment 4 Gonçalo Negrier Duarte 2024-04-23 07:22:07 UTC
Also giving a better just found the test work the same way that gui-libs/gtk-layer-shell.
Gonna try the same logic and see if solves. 

I yesterday disable test since didn't know that vala eclass was a thing (basically pkgconfig need vala-setup to find vapigen)
Comment 5 Gonçalo Negrier Duarte 2024-04-23 07:32:26 UTC
(In reply to Gonçalo Negrier Duarte from comment #4)
> Also giving a better just found the test work the same way that
> gui-libs/gtk-layer-shell.
> Gonna try the same logic and see if solves. 
> 
> I yesterday disable test since didn't know that vala eclass was a thing
> (basically pkgconfig need vala-setup to find vapigen)

This error dosent look good:
"test/unit-tests/meson.build:4:24: ERROR: Unknown variable "gtk_layer_shell"."
Comment 6 Gonçalo Negrier Duarte 2024-04-23 07:36:01 UTC
I think I find out was doing this, because 9999 is working fine.

I gonna try to apply this patch: https://github.com/Cu3PO42/gtk-session-lock/commit/a92080b164df7553aa250d43f90965535a3050ba.diff
Comment 7 Gonçalo Negrier Duarte 2024-04-23 07:56:44 UTC
Upstream have problem with the test I gonna close this with a commit, that improves the ebuild and enable the test, but it will fail anyway
Comment 8 Gonçalo Negrier Duarte 2024-04-23 08:00:49 UTC
(In reply to Gonçalo Negrier Duarte from comment #6)
> I think I find out was doing this, because 9999 is working fine.
> 
> I gonna try to apply this patch:
> https://github.com/Cu3PO42/gtk-session-lock/commit/
> a92080b164df7553aa250d43f90965535a3050ba.diff

Also correcting what I said above 9999 is not working with test enable. I forget to enable the test useflag. Even if I remove the error to disable test added in the commit above I gonna get this:

```bash
FAILED: test/mock-server/mock-server.p/overrides.c.o
clang -Itest/mock-server/mock-server.p -Itest/mock-server -I../gtk-session-lock-9999/test/mock-server -Itest/test-common -I../gtk-session-lock-9999/test/test-common -I/usr/lib64/libffi/include -flto=thin -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Wpedantic -std=gnu11 -Wno-pedantic -Werror=unused-function -fvisibility=hidden -march=native -O3 -pipe -fdiagnostics-color=always -Wno-incompatible-pointer-types -Wno-unused-parameter -MD -MQ test/mock-server/mock-server.p/overrides.c.o -MF test/mock-server/mock-server.p/overrides.c.o.d -o test/mock-server/mock-server.p/overrides.c.o -c ../gtk-session-lock-9999/test/mock-server/overrides.c
In file included from ../gtk-session-lock-9999/test/mock-server/overrides.c:12:
../gtk-session-lock-9999/test/mock-server/mock-server.h:25:10: fatal error: 'xdg-shell-server.h' file not found
   25 | #include "xdg-shell-server.h"
      |          ^~~~~~~~~~~~~~~~~~~~
1 error generated.
```
Comment 9 Larry the Git Cow gentoo-dev 2024-04-23 10:26:14 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=c10009663ba4de3f02a02963d2c8b977b67fc222

commit c10009663ba4de3f02a02963d2c8b977b67fc222
Author:     Gonçalo Negrier Duarte <gonegrier.duarte@gmail.com>
AuthorDate: 2024-04-23 07:16:05 +0000
Commit:     Gonçalo Negrier Duarte <gonegrier.duarte@gmail.com>
CommitDate: 2024-04-23 07:26:27 +0000

    gui-libs/gtk-session-lock: improve ebuild and fix tests
    
    * tests on gtk-session-lock work very similar to gtk-layer-shell
    * the same logic was applied, also most of the depedency are the same
    * also add gtk-layer-shell as depedency for test only
    
    Closes: https://bugs.gentoo.org/930470
    Signed-off-by: Gonçalo Negrier Duarte <gonegrier.duarte@gmail.com>

 .../gtk-session-lock-0.2.0-r3.ebuild               | 42 ----------------
 .../gtk-session-lock-0.2.0-r4.ebuild               | 56 ++++++++++++++++++++++
 gui-libs/gtk-session-lock/metadata.xml             |  4 --
 3 files changed, 56 insertions(+), 46 deletions(-)