Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 930337 - kde-apps/thumbnailers: missing RDEPEND for PDF preview in Dolphin
Summary: kde-apps/thumbnailers: missing RDEPEND for PDF preview in Dolphin
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: InOverlay, PullRequest
Depends on:
Blocks: 937987
  Show dependency tree
 
Reported: 2024-04-20 15:31 UTC by John-Henry Lim
Modified: 2024-08-15 17:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info kde-apps/thumbnailers > emerge-info.txt (emerge-info.txt,9.56 KB, text/plain)
2024-04-20 15:31 UTC, John-Henry Lim
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John-Henry Lim 2024-04-20 15:31:29 UTC
Created attachment 891186 [details]
emerge --info kde-apps/thumbnailers > emerge-info.txt

For the longest time, I was stumped trying to figure out why I couldn't get PDF preview in Dolphin to work despite having kdegraphics-thumbnailers already. Today, out of desperation, I emerged kde-apps/okular which I previously did not have installed. Magically, PDF previews started working.

I don't believe kdegraphics-thumbnailers actually depends on okular, but what is clear is that theres a missing RDEPEND. When I have time, I will try and trace down which dependency okular dragged in that fixed thumbnailers, or stare at the source code of thumbnailers I guess. Will reply to this thread then.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-15 12:16:54 UTC
I will take a brief look.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-15 12:27:56 UTC
kio has PreviewJob, I assume somewhere in Okular registers it as a handler w/ kio.

i.e. I think really it does "directly" depend on it, at least if you want the PDF functionality. It's just the nature of plugins/optional handlers.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-15 12:31:30 UTC
Actually, I'm not so sure.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-15 12:32:14 UTC
In ps/gscreator.cpp, it shells out to `gs` from ghostscript-gpl in a bunch of cases.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-07-15 12:40:24 UTC
So, for ps/, per https://invent.kde.org/graphics/kdegraphics-thumbnailers/-/blob/master/ps/gscreator.cpp?ref_type=heads#L22, we need to RDEPEND on ghostscript-gpl & app-text/dvipsk?
Comment 6 Andreas Sturmlechner gentoo-dev 2024-08-11 13:25:16 UTC
looks like it.
Comment 7 Larry the Git Cow gentoo-dev 2024-08-15 07:39:47 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=fb266614d8885555026df51191c92a8696e1bb8c

commit fb266614d8885555026df51191c92a8696e1bb8c
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-08-11 21:06:22 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-08-15 07:37:00 +0000

    media-gfx/kio-ps-thumbnailer: new package, add 9999
    
    Bug: https://bugs.gentoo.org/930337
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../kio-ps-thumbnailer-9999.ebuild                 | 43 ++++++++++++++++++++++
 media-gfx/kio-ps-thumbnailer/metadata.xml          | 12 ++++++
 2 files changed, 55 insertions(+)
Comment 8 Larry the Git Cow gentoo-dev 2024-08-15 17:48:06 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=60fe15791f5c41f5494e4a01daaa66bcd3ed7a77

commit 60fe15791f5c41f5494e4a01daaa66bcd3ed7a77
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-08-15 08:18:41 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-08-15 17:46:51 +0000

    media-gfx/kio-ps-thumbnailer: new package, add 24.05.2
    
    Bug: https://bugs.gentoo.org/930337
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-gfx/kio-ps-thumbnailer/Manifest              |  1 +
 .../kio-ps-thumbnailer-24.05.2.ebuild              | 43 ++++++++++++++++++++++
 media-gfx/kio-ps-thumbnailer/metadata.xml          | 12 ++++++
 3 files changed, 56 insertions(+)