Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 930170 - dev-libs/protobuf: the SLOT check does not consider macOS-style ".dylib" suffix
Summary: dev-libs/protobuf: the SLOT check does not consider macOS-style ".dylib" suffix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: ARM64 OS X
: Normal normal
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 930174
  Show dependency tree
 
Reported: 2024-04-17 20:26 UTC by ZongyuZ
Modified: 2024-08-25 15:21 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
the proposed patch (protobuf-darwin-dylib.patch,886 bytes, patch)
2024-04-17 20:26 UTC, ZongyuZ
Details | Diff
the build.log (protobuf-darwin-failure.log,219.61 KB, application/octet-stream)
2024-04-17 20:30 UTC, ZongyuZ
Details
the emerge --info output (emerge --info.output,5.80 KB, text/plain)
2024-04-17 20:31 UTC, ZongyuZ
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ZongyuZ 2024-04-17 20:26:02 UTC
Created attachment 891015 [details, diff]
the proposed patch

`deb-libs/protobuf` checks whether the filename of lib matches the `libprotobuf.so.${SLOT#*/}` pattern.

However, in a prefix of an `arm64-macos` system, the corresponding filename would be `libprotobuf.${SLOT#*/}.dylib`, which will cause a failure.

The package itself compiles well.

I propose a patch here to check the `CHOST` variable, and set the corresponding filename accordingly.
It will help emerge this file.

This bug report may also serve as a keywording request for `protobuf` :)
Comment 1 ZongyuZ 2024-04-17 20:30:17 UTC
Created attachment 891016 [details]
the build.log
Comment 2 ZongyuZ 2024-04-17 20:31:39 UTC
Created attachment 891017 [details]
the emerge --info output
Comment 3 Fabian Groffen gentoo-dev 2024-04-18 06:12:05 UTC
it could use libprotobuf$(get_libname(${SLOT})) which is made for this purpose
Comment 4 Larry the Git Cow gentoo-dev 2024-08-25 15:21:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=467e4946e9d54c58f5c20455181181eb04759762

commit 467e4946e9d54c58f5c20455181181eb04759762
Author:     Fabian Groffen <grobian@gentoo.org>
AuthorDate: 2024-08-25 15:17:43 +0000
Commit:     Fabian Groffen <grobian@gentoo.org>
CommitDate: 2024-08-25 15:21:19 +0000

    dev-libs/protobuf-27.2: fix SLOT check for non-.so platforms
    
    use get_libname to check for appropriate output, may help with bug #891469
    
    Bug: https://bugs.gentoo.org/891469
    Closes: https://bugs.gentoo.org/930170
    Signed-off-by: Fabian Groffen <grobian@gentoo.org>

 dev-libs/protobuf/protobuf-27.2.ebuild | 8 ++++----
 dev-libs/protobuf/protobuf-9999.ebuild | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)