Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 930142 - kde-frameworks/kio-5.115.0[X]: Could NOT find X11
Summary: kde-frameworks/kio-5.115.0[X]: Could NOT find X11
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: InOverlay
: 939177 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-04-17 13:11 UTC by Esteve Varela Colominas
Modified: 2024-09-07 20:24 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log (build.log,4.68 KB, application/octet-stream)
2024-04-17 13:11 UTC, Esteve Varela Colominas
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Esteve Varela Colominas 2024-04-17 13:11:49 UTC
Created attachment 890966 [details]
build log

CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find X11 (missing: X11_X11_INCLUDE_PATH)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake/Modules/FindX11.cmake:665 (find_package_handle_standard_args)
  /usr/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  /usr/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake:45 (find_dependency)
  CMakeLists.txt:86 (find_package)
Comment 1 Esteve Varela Colominas 2024-04-17 13:13:00 UTC
x11-base/xorg-proto is missing from BDEPEND
Comment 2 Esteve Varela Colominas 2024-04-17 13:15:54 UTC
I meant DEPEND, not BDEPEND
Comment 3 Andreas Sturmlechner gentoo-dev 2024-04-17 15:36:53 UTC
Real error is coming from kde-frameworks/kwindowsystem[X] which is trying to find libX11 in KF5WindowSystemConfig.cmake ...
Comment 4 Esteve Varela Colominas 2024-04-19 09:34:50 UTC
kde-frameworks/kwindowsystem[X] has a DEPEND on xorg-proto, but since it's a build-time dependency (as it should be), it doesn't propagate as a build-time dependency to other packages.

kde-apps/kio-extras-23.08.5 has the same problem, by the way.
Comment 5 Andreas Sturmlechner gentoo-dev 2024-04-19 11:53:00 UTC
Yes. As I said. But the solution can't be to add this in every kde-frameworks/kwindowsystem[X] revdep.
Comment 6 Andreas Sturmlechner gentoo-dev 2024-04-19 12:07:39 UTC
(In reply to Esteve Varela Colominas from comment #4)
> kde-apps/kio-extras-23.08.5 has the same problem, by the way.
If you want numbers, there are currently 38 revdeps of kde-frameworks/kwindowsystem[X].
Comment 7 Esteve Varela Colominas 2024-04-19 14:39:05 UTC
And none of those DEPEND on xorg-proto? Odd
Comment 8 Andreas Sturmlechner gentoo-dev 2024-04-19 15:12:01 UTC
(In reply to Esteve Varela Colominas from comment #7)
> And none of those DEPEND on xorg-proto? Odd
Not unless they also depend on x11-libs/libX11 themselves, no.
Comment 9 Esteve Varela Colominas 2024-04-19 17:07:37 UTC
See - here's the thing. Even if you DEPEND on libX11 you're not pulling in xorg-proto. Just like with kwindowsystem, xorg-proto is in libX11's DEPEND, not RDEPEND. If you want to solve this without putting xorg-proto in any package that compiles anything that indirectly includes libX11, you're gonna have to modify libX11, rather...

That said, as far as I'm aware, most things solve this by putting xorg-proto in DEPEND.
Comment 10 Andreas Sturmlechner gentoo-dev 2024-04-20 08:42:46 UTC
You've misunderstood. Packages depending on x11-libs/libX11 have xorg-proto in DEPEND.
Comment 11 Esteve Varela Colominas 2024-04-25 16:29:35 UTC
I see, in that case I don't really understand your proposed solution...
Comment 12 Andreas Sturmlechner gentoo-dev 2024-05-20 21:45:21 UTC
I have not proposed a solution yet. This is the list of applications that would be lacking xorg-proto in DEPEND, *not* because they themselves depend on libX11 but only because one of their dependencies (kwindowsystem[X]) does.

> gui-apps/xwaylandvideobridge/xwaylandvideobridge-9999.ebuild
> kde-apps/amor/amor-9999.ebuild
> kde-apps/kalarm/kalarm-9999.ebuild
> kde-apps/kate/kate-9999.ebuild
> kde-apps/kmail/kmail-9999.ebuild
> kde-apps/kmix/kmix-9999.ebuild
> kde-apps/knotes/knotes-9999.ebuild
> kde-apps/kontactinterface/kontactinterface-9999.ebuild
> kde-apps/spectacle/spectacle-9999.ebuild
> kde-apps/yakuake/yakuake-9999.ebuild
> kde-frameworks/kglobalaccel/kglobalaccel-5.239.9999.ebuild
> kde-frameworks/kio/kio-9999.ebuild
> kde-frameworks/kstatusnotifieritem/kstatusnotifieritem-9999.ebuild
> kde-frameworks/kwallet/kwallet-9999.ebuild
> kde-misc/colord-kde/colord-kde-9999.ebuild
> kde-misc/zanshin/zanshin-9999.ebuild
> kde-plasma/bluedevil/bluedevil-9999.ebuild
> kde-plasma/breeze/breeze-9999.ebuild
> kde-plasma/kactivitymanagerd/kactivitymanagerd-9999.ebuild
> kde-plasma/kde-cli-tools/kde-cli-tools-9999.ebuild
> kde-plasma/kglobalacceld/kglobalacceld-9999.ebuild
> kde-plasma/plasma-activities/plasma-activities-9999.ebuild
> kde-plasma/polkit-kde-agent/polkit-kde-agent-9999.ebuild
> kde-plasma/powerdevil/powerdevil-9999.ebuild
> net-irc/konversation/konversation-9999.ebuild
Comment 13 Andreas Sturmlechner gentoo-dev 2024-09-07 09:55:37 UTC
xorg-proto was moved to kwindowsystem[X] with commit 4ad67874d4d76521d5af399aa7c033a64c5adda5 in kde overlay, for 6.6.0 version bump.
Comment 14 Andreas Sturmlechner gentoo-dev 2024-09-07 10:00:59 UTC
(In reply to Andreas Sturmlechner from comment #13)
> xorg-proto was moved to kwindowsystem[X] with commit
> 4ad67874d4d76521d5af399aa7c033a64c5adda5 in kde overlay, for 6.6.0 version
> bump.
*to RDEPEND with kwindowsystem[X] (previously it was DEPEND)
Comment 15 Esteve Varela Colominas 2024-09-07 11:42:44 UTC
I wonder if a change like this would be better done somewhere higher up the dependency chain. I'm constantly hitting odd build error messages due to this package missing from the system, and I'm not sure if I should be reporting issues for all of them...
That, or modifying portage to have a way to signal packages that are transitive BDEPENDs...
Comment 16 Andreas Sturmlechner gentoo-dev 2024-09-07 12:01:22 UTC
*** Bug 939177 has been marked as a duplicate of this bug. ***
Comment 17 Andreas Sturmlechner gentoo-dev 2024-09-07 12:04:49 UTC
In case you're talking about KDE Frameworks revdeps, kde-frameworks/kwindowsysten[X] is exactly the right place.
Comment 18 Larry the Git Cow gentoo-dev 2024-09-07 17:52:42 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d24dc15c304f8837da31416965263ad52bbb06be

commit d24dc15c304f8837da31416965263ad52bbb06be
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-09-07 08:41:51 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-09-07 17:52:05 +0000

    kde-frameworks/kwindowsystem: Move x11-base/xorg-proto to USE=X RDEPEND
    
    X11/Xlib.h is included in public header kkeyserver.h, xorg-proto required by
    KF6WindowSystemConfig.cmake
    
    Bug: https://bugs.gentoo.org/930142
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../{kwindowsystem-6.5.0.ebuild => kwindowsystem-6.5.0-r1.ebuild}     | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 19 Esteve Varela Colominas 2024-09-07 18:55:26 UTC
Nah, I was referring to non-kde packages that have the same issue. Basically anything that uses libX11 or a transitive header dependency in DEPEND.
Comment 20 Andreas Sturmlechner gentoo-dev 2024-09-07 20:24:28 UTC
That would require separate bugs for those packages, if they aren't existing already.