Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 930132 - gui-wm/hyprland-0.39.1 installs bash completion in legacy location
Summary: gui-wm/hyprland-0.39.1 installs bash completion in legacy location
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Julien Roy
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-04-17 07:32 UTC by Agostino Sarubbo
Modified: 2024-04-22 07:37 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,609.79 KB, text/plain)
2024-04-17 07:32 UTC, Agostino Sarubbo
Details
patch to fix bash-completion path (hyprland-0.39.1-bash-completion.patch,1.52 KB, patch)
2024-04-17 11:09 UTC, Yixun Lan
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-04-17 07:32:03 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: gui-wm/hyprland-0.39.1 installs bash completion in legacy location.
Discovered on: amd64 (internal ref: ci)
Comment 1 Agostino Sarubbo gentoo-dev 2024-04-17 07:32:04 UTC
Created attachment 890959 [details]
build.log

build log and emerge --info
Comment 2 Yixun Lan archtester gentoo-dev 2024-04-17 11:09:07 UTC
Created attachment 890961 [details, diff]
patch to fix bash-completion path

@MrRoy can you check this patch? it works for me, also you might report this to upstream..
Comment 3 Julien Roy 2024-04-17 11:10:36 UTC
@dlan: thanks for the patch. I will only have time to check it out tomorrow, but I'll get back to you then.
Comment 4 Julien Roy 2024-04-19 17:43:06 UTC
I tested your patch and it fixes the problem for me.
I submitted PR https://github.com/hyprwm/Hyprland/pull/5653 upstream.

Do you think it's worth it to revbump 0.39.1 to fix this? Since it's a minor issue, I would just wait until next release.
Comment 5 Yixun Lan archtester gentoo-dev 2024-04-19 21:43:08 UTC
(In reply to Julien from comment #4)
> I tested your patch and it fixes the problem for me.
> I submitted PR https://github.com/hyprwm/Hyprland/pull/5653 upstream.
> 
great!

> Do you think it's worth it to revbump 0.39.1 to fix this? Since it's a minor
> issue, I would just wait until next release.
Yes, a revbump sounds good to me, if it's a problem, why not fix it?
this will eventually make bash completion work, although user may compile it one more time (which I personally don't mind..)
Comment 6 Larry the Git Cow gentoo-dev 2024-04-20 19:25:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cf23af1c4bef55a830a0c216dc39714cc46efbc9

commit cf23af1c4bef55a830a0c216dc39714cc46efbc9
Author:     Julien Roy <julien@jroy.ca>
AuthorDate: 2024-04-20 14:26:25 +0000
Commit:     Arthur Zamarin <arthurzam@gentoo.org>
CommitDate: 2024-04-20 19:19:54 +0000

    gui-wm/hyprland: add patch for bash completions
    
    Closes: https://bugs.gentoo.org/930132
    Signed-off-by: Julien Roy <julien@jroy.ca>
    Closes: https://github.com/gentoo/gentoo/pull/36331
    Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>

 .../files/bash-completion-fix-0.39.1.patch         | 22 ++++++++++++++++++++++
 ...and-0.39.1.ebuild => hyprland-0.39.1-r1.ebuild} |  6 ++++++
 2 files changed, 28 insertions(+)