Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 929927 - dev-lang/fennel: bring back lua_single_target_luajit for AMD64
Summary: dev-lang/fennel: bring back lua_single_target_luajit for AMD64
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-13 15:49 UTC by dm9pZCAq
Modified: 2024-04-13 22:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dm9pZCAq 2024-04-13 15:49:04 UTC
I saw that it was removed in bug #923281 due to failed test.
For me all tests for dev-lang/fennel-1.4.0-r1 with lua_single_target_luajit on AMD64 passes.

Also here https://git.sr.ht/~technomancy/fennel#to-build-fennel-from-source mentioned that fennel supports luajit.

For example I need fennel to use it as configuration language for app-editors/neovim-9999 with lua_single_target_luajit (I have 2000 lines config in fennel and it also works as expected)

So can you pleas bring back this use flag at least for AMD64?




>>> Test phase: dev-lang/fennel-1.4.0-r1
make -j9 -l8 test
/usr/bin/luajit bootstrap/aot.lua test/faith.fnl > test/faith.lua
fatal: not a git repository (or any parent up to mount point /var/tmp)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

Starting module test.core with 17 test(s)
................
Starting module test.mangling with 1 test(s)
.
Starting module test.quoting with 3 test(s)
...
Starting module test.bit with 2 test(s)
..
Starting module test.fennelview with 11 test(s)
...........
Starting module test.parser with 6 test(s)
......
Starting module test.failures with 11 test(s)
...........
Starting module test.repl with 25 test(s)
.........................
Starting module test.cli with 3 test(s)
...
Starting module test.macro with 22 test(s)
......................
Starting module test.linter with 4 test(s)
....
Starting module test.loops with 6 test(s)
......
Starting module test.misc with 11 test(s)
..........
Starting module test.searcher with 2 test(s)
..
Starting module test.api with 1 test(s)
.

Testing finished in approximately 1 second(s) with 1821 assertion(s)
123 passed, 0 failed, 0 error(s), 0 skipped
0.94 second(s) of CPU time used
Comment 1 Maciej Barć gentoo-dev 2024-04-13 17:48:55 UTC
Do you load the fennel library in nvim?
Don't you 1st transile fennel -> lua and then load it in neovim? 
If so, then you cna just emerge fennel with normal USE flags.
Comment 2 dm9pZCAq 2024-04-13 17:59:57 UTC
Personally I use it as library
```lua
-- init.lua

local fennel = require("fennel")

-- ...
```
but in general why remove lua_single_target_luajit on AMD64 if it works on AMD64?
Can you remove it just for ppc?
Comment 3 Maciej Barć gentoo-dev 2024-04-13 18:01:59 UTC
(In reply to dm9pZCAq from comment #2)
> Personally I use it as library

Ok, I see.

> Can you remove it just for ppc?

Yea, this is possible.
Comment 4 Larry the Git Cow gentoo-dev 2024-04-13 22:56:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e63f446626cf51238f60dadc097a6e502363db6b

commit e63f446626cf51238f60dadc097a6e502363db6b
Author:     Maciej Barć <xgqt@gentoo.org>
AuthorDate: 2024-04-13 22:49:55 +0000
Commit:     Maciej Barć <xgqt@gentoo.org>
CommitDate: 2024-04-13 22:55:49 +0000

    dev-lang/fennel: remove failing ppc tests
    
    Closes: https://bugs.gentoo.org/929927
    Signed-off-by: Maciej Barć <xgqt@gentoo.org>

 dev-lang/fennel/{fennel-1.4.0-r1.ebuild => fennel-1.4.0-r2.ebuild} | 6 +++++-
 dev-lang/fennel/{fennel-1.4.2.ebuild => fennel-1.4.2-r1.ebuild}    | 6 +++++-
 2 files changed, 10 insertions(+), 2 deletions(-)