Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 929640 - media-libs/libffado: needs upgrade to Python 3.12 (PythonCompatUpdate)
Summary: media-libs/libffado: needs upgrade to Python 3.12 (PythonCompatUpdate)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 921826
  Show dependency tree
 
Reported: 2024-04-13 08:46 UTC by Michał Górny
Modified: 2024-07-04 14:40 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for Python 3.12 to work (libffado-2.4.8-fix-python-3-12.patch,3.10 KB, patch)
2024-06-19 12:17 UTC, Maxim Buzdalov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-04-13 08:46:33 UTC
This package does not support Python 3.12.  Please test it with Python 3.12 as a matter of urgency as the default will change in early June, as per message on gentoo-dev: https://www.mail-archive.com/gentoo-dev@lists.gentoo.org/msg99104.html.  Please check the information provided in the tracker.  Ask in #gentoo-python on IRC if need any help.
Comment 1 inkflaw 2024-05-09 08:45:57 UTC
Simply add python3.12 in ebuild does not work, it's a bug of ffado.
Comment 2 inkflaw 2024-05-09 08:47:44 UTC
Also see (fix way, if we need, we can patch it by the way): https://github.com/neovim/pynvim/issues/538
Comment 3 imese 2024-06-05 02:27:12 UTC
As of this morning the bug still exists.

My post on forum:

https://forums.gentoo.org/viewtopic-p-8829084.html#8829084
Comment 4 Paul Gover 2024-06-06 07:04:07 UTC
I've hit this one.

Temporarily removing USE=ieee1394 removes the dependency in libffado, which is a workaround for me as I rarely use Firewire at the moment (for my old camcorder)
Comment 5 Maxim Buzdalov 2024-06-19 12:17:18 UTC
Created attachment 896098 [details, diff]
Patch for Python 3.12 to work

With this patch, libffado-2.4.8 at least compiles normally.
Based on what's changed (imp => importlib, use proper escape sequences), the main part should still work.
Comment 6 Andreas Sturmlechner gentoo-dev 2024-06-19 14:42:11 UTC
Thanks, did you take this from (or submit to) upstream?
Comment 7 Maxim Buzdalov 2024-06-19 20:05:21 UTC
(In reply to Andreas Sturmlechner from comment #6)
> Thanks, did you take this from (or submit to) upstream?

No, I just experimented with this in my overlay. I am not on ffado mailing lists, so currently I don't have any way to submit this upstream.
Comment 8 Pablo Wagner 2024-07-04 01:37:20 UTC
Apparently, this is fixed in FFADO 2.4.9. Snip from the changelog:

 -Remove build-time checks for utilities that are not used (pyuic).

See: https://www.ffado.org/posts/ffado-2.4.9-release
Comment 9 Miroslav Šulc gentoo-dev 2024-07-04 14:23:39 UTC
i'll apply the patch from here (thanks) and bump to 2.4.9 in a few mins...
Comment 10 Larry the Git Cow gentoo-dev 2024-07-04 14:24:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=69364e35bd5a05ed5c26f8806dbfdaf63741c32e

commit 69364e35bd5a05ed5c26f8806dbfdaf63741c32e
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2024-07-04 14:24:10 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2024-07-04 14:24:19 +0000

    media-libs/libffado: added python 3.12
    
    Closes: https://bugs.gentoo.org/929640
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../libffado-2.4.7-fix-config-load-crash.patch     |  2 -
 .../libffado/files/libffado-2.4.8-python3.12.patch | 82 ++++++++++++++++++++++
 media-libs/libffado/libffado-2.4.8.ebuild          |  3 +-
 3 files changed, 84 insertions(+), 3 deletions(-)
Comment 11 Miroslav Šulc gentoo-dev 2024-07-04 14:40:23 UTC
well, i'm not gonna bump it in the end. the changes in 2.4.9 are non-trivial, so anybody feel free to have a look at it and provide a pr.