Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 929007 - app-emulation/virtualbox-guest-additions: Drop dependency on x11-drivers/xf86-video-vboxvideo
Summary: app-emulation/virtualbox-guest-additions: Drop dependency on x11-drivers/xf86...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Viorel Munteanu
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-09 13:23 UTC by Matt Turner
Modified: 2024-11-06 18:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2024-04-09 13:23:27 UTC
I believe x11-drivers/xf86-video-vboxvideo is not useful with the kernel modesetting driver (CONFIG_DRM_VBOXVIDEO).

xf86-video-vboxvideo is only intended to be used these days on operating systems without kernel modesetting (e.g. Solaris).

I would like to remove the package. Please drop the dependency from app-emulation/virtualbox-guest-additions if possible.
Comment 1 Viorel Munteanu gentoo-dev 2024-04-09 14:56:00 UTC
As far as I know, there are 2 video drivers that can be used with Guest Additions:

- kernel module vboxvideo + xorg module x11-drivers/xf86-video-vboxvideo for the VBoxSVGA graphics controller, or
- kernel module vmwgfx + xorg module x11-drivers/xf86-video-vmware for the VMSVGA graphics controller - this is the recommended one.

I think VBoxSVGA + vboxvideo are becoming obsolete, but it still depends on how the virtual machine is configured.

So the best solution would be to keep using the `gui` USE flag for building the `VBoxClient` binaries, and add a new `vboxvideo` flag that will build the `vboxvideo` module and depend on x11-drivers/xf86-video-vboxvideo.

Maybe also and add optfeature for x11-drivers/xf86-video-vmware.

What do you think?
Comment 2 Matt Turner gentoo-dev 2024-04-10 17:05:50 UTC
(In reply to Viorel Munteanu from comment #1)
> As far as I know, there are 2 video drivers that can be used with Guest
> Additions:
> 
> - kernel module vboxvideo + xorg module x11-drivers/xf86-video-vboxvideo for
> the VBoxSVGA graphics controller, or

This is the configuration I'm saying is replaced with CONFIG_DRM_VBOXVIDEO. With CONFIG_DRM_VBOXVIDEO, x11-drivers/xf86-video-vboxvideo is not needed.

> - kernel module vmwgfx + xorg module x11-drivers/xf86-video-vmware for the
> VMSVGA graphics controller - this is the recommended one.
> 
> I think VBoxSVGA + vboxvideo are becoming obsolete, but it still depends on
> how the virtual machine is configured.
> 
> So the best solution would be to keep using the `gui` USE flag for building
> the `VBoxClient` binaries, and add a new `vboxvideo` flag that will build
> the `vboxvideo` module and depend on x11-drivers/xf86-video-vboxvideo.

I don't know whata VBoxClient is, but I don't think x11-drivers/xf86-video-vboxvideo is a dependency since it's just an Xorg driver.

> Maybe also and add optfeature for x11-drivers/xf86-video-vmware.

Seems like a good idea.
Comment 3 Larry the Git Cow gentoo-dev 2024-04-10 18:17:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0eacf0664dad7d850038c2afc9ded15fe881f5b9

commit 0eacf0664dad7d850038c2afc9ded15fe881f5b9
Author:     Viorel Munteanu <ceamac@gentoo.org>
AuthorDate: 2024-04-10 16:35:33 +0000
Commit:     Viorel Munteanu <ceamac@gentoo.org>
CommitDate: 2024-04-10 18:17:52 +0000

    app-emulation/virtualbox-guest-additions: remove a dependency
    
    Remove dependency on x11-drivers/xf86-video-vboxvideo.
    Move the long elog sequence to readme.gentoo-r1.
    Add more warnings and kernel checks.
    
    Closes: https://bugs.gentoo.org/929007
    Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>

 .../virtualbox-guest-additions-7.0.14-r3.ebuild    | 297 +++++++++++++++++++++
 1 file changed, 297 insertions(+)
Comment 4 Viorel Munteanu gentoo-dev 2024-04-10 18:22:17 UTC
You are right, I checked.

I removed the dependency, it was loaded but did nothing.  The modesetting driver would take over.

Also the modesetting driver can work just as fine instead of the vmware one, so I did not add the optfeature after all.

Thanks!
Comment 5 Larry the Git Cow gentoo-dev 2024-11-06 18:42:21 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7cc667cddaf0355400bb7c35680f30e24f403e7b

commit 7cc667cddaf0355400bb7c35680f30e24f403e7b
Author:     Matt Turner <mattst88@gentoo.org>
AuthorDate: 2024-11-06 18:38:42 +0000
Commit:     Matt Turner <mattst88@gentoo.org>
CommitDate: 2024-11-06 18:42:17 +0000

    profiles: Mask xf86-video-vboxvideo for removal
    
    Bug: https://bugs.gentoo.org/929007
    Signed-off-by: Matt Turner <mattst88@gentoo.org>

 profiles/arch/amd64/use.mask | 1 -
 profiles/arch/x86/use.mask   | 1 -
 profiles/package.mask        | 7 +++++++
 3 files changed, 7 insertions(+), 2 deletions(-)