Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 928933 - profiles/releases/23.0/make.defaults: drop or relocate USE=zstd
Summary: profiles/releases/23.0/make.defaults: drop or relocate USE=zstd
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Profiles (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andreas K. Hüttel
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-08 11:56 UTC by Michael Orlitzky
Modified: 2024-04-12 05:57 UTC (History)
8 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2024-04-08 11:56:36 UTC
As discussed on gentoo-dev:

This default doesn't actually solve the stated problem, and setting it in a high-level profile causes new ones for users who want it disabled. The obvious solution to revert to the status quo is to set USE="-zstd", but that has the dangerous side-effect of overriding IUSE defaults in packages where they are important. For example, sys-apps/kmod uses +zstd to ensure that your kernel will boot if you choose zstd compression for modules; helpful, because there's no other way for the package manager to track that dependency.

There are other more appropriate places for USE=zstd:

  * In a profile that the user has to choose, like the desktop profile.
  * In the packages themselves, as IUSE defaults.
  * Nowhere :) All Gentoo users know how to set USE=zstd if they want
    zstd support. You learn this before you even boot into your first
    Gentoo install.
Comment 1 Chris Pritchard 2024-04-08 12:02:47 UTC
If you're looking for consensus I've been following the threads on gentoo-dev and would agree with this change to the profile. There are other, more sensible, places to put this as a default directly in the packages where it's important.
Comment 2 Larry the Git Cow gentoo-dev 2024-04-09 21:48:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bbe2b57efbc894c3a06c283927ae245d0d1b6454

commit bbe2b57efbc894c3a06c283927ae245d0d1b6454
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2024-04-09 21:44:36 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2024-04-09 21:48:17 +0000

    profiles, 23.0: Undo USE="lzma zstd", except for toolchain where zstd makes sense
    
    As discussed on gentoo-dev and in toolchain / base-system teams.
    
    Closes: https://bugs.gentoo.org/928932
    Closes: https://bugs.gentoo.org/928933
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 profiles/releases/23.0/make.defaults |  9 +++------
 profiles/releases/23.0/package.use   | 10 ++++++++++
 2 files changed, 13 insertions(+), 6 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2024-04-09 22:34:57 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5d43599359d124a9e4c7f2c9c575883d13b386dc

commit 5d43599359d124a9e4c7f2c9c575883d13b386dc
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-04-09 22:34:22 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-04-09 22:34:22 +0000

    profiles/releases/23.0: enable zstd for sys-devel/lld too
    
    It has to match LLVM or we get autounmask hell.
    
    Bug: https://bugs.gentoo.org/928933
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/releases/23.0/package.use | 1 +
 1 file changed, 1 insertion(+)