Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 928427 - dev-python/nbformat: patch hardcodes wrong version
Summary: dev-python/nbformat: patch hardcodes wrong version
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-02 13:44 UTC by Michał Górny
Modified: 2024-05-24 05:11 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2024-04-02 13:44:43 UTC
[project]
 name = "nbformat"
-dynamic = ["version"]
+version = "5.7.1"


Sigh…
Comment 1 Larry the Git Cow gentoo-dev 2024-04-02 13:56:51 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c52ef81c670d0d53f9fc5f42e3a28fe78ccdf27d

commit c52ef81c670d0d53f9fc5f42e3a28fe78ccdf27d
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-04-02 13:52:43 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-04-02 13:53:46 +0000

    dev-python/nbformat: Fix hardcoded version number
    
    Put the correct version number into the patch, to solve the problem
    until the revbump is keyworded and stabilized.
    
    Closes: https://bugs.gentoo.org/928427
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/nbformat/files/nbformat-5.7.1-no-node.patch                  | 2 +-
 .../nbformat/{nbformat-5.10.3.ebuild => nbformat-5.10.3-r1.ebuild}      | 0
 2 files changed, 1 insertion(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e7c8021b3f55bf99c4d06ec2a5fb1776e40aecdc

commit e7c8021b3f55bf99c4d06ec2a5fb1776e40aecdc
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2024-04-02 13:51:55 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2024-04-02 13:53:46 +0000

    dev-python/nbformat: Use hatch-nodejs-version
    
    Bug: https://bugs.gentoo.org/928427
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/nbformat/nbformat-5.10.3-r2.ebuild | 46 +++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)
Comment 2 Benda Xu gentoo-dev 2024-05-24 03:25:11 UTC
(In reply to Michał Górny from comment #0)
> [project]
>  name = "nbformat"
> -dynamic = ["version"]
> +version = "5.7.1"
> 
> 
> Sigh…

Well, hatch-nodejs-version is nothing but to extract a version number from nodejs.  That feels cursed.

That said, since hatch-nodejs-version is packaged (thanks!), the status quo is better.
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-05-24 05:11:55 UTC
Sure, but in that case, you should've added a placeholder then sedded it or something..