Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 928345 - kde-frameworks/extra-cmake-modules: KDEInstallDirs(5|6).cmake use /usr/lib64/libexec instead of /usr/libexec
Summary: kde-frameworks/extra-cmake-modules: KDEInstallDirs(5|6).cmake use /usr/lib64/...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 926828
  Show dependency tree
 
Reported: 2024-04-01 06:39 UTC by Gino McCarty
Modified: 2024-11-17 16:05 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gino McCarty 2024-04-01 06:39:23 UTC
```
# ls -la /usr/lib64/libexec/
total 1548
drwxr-xr-x   5 root root   4096 Mar 30 00:16 .
drwxr-xr-x 109 root root 147456 Mar 31 22:51 ..
drwxr-xr-x   2 root root   4096 Mar 29 22:54 kauth
drwxr-xr-x   3 root root   4096 Mar 29 22:52 kf5
-rwxr-xr-x   1 root root 205264 Mar 29 22:49 kio-fuse
-rwxr-xr-x   1 root root  65504 Mar 29 20:39 kpmcore_externalcommand
-rwxr-xr-x   1 root root 159600 Mar 29 23:16 kscreenlocker_greet
drwxr-xr-x   2 root root   4096 Mar 29 22:54 ksysguard
-rwxr-xr-x   1 root root  30504 Mar 29 21:51 org-kde-kf5-kwayland-testserver
-rwxr-xr-x   1 root root  84728 Mar 29 22:36 polkit-kde-authentication-agent-1
-rwxr-xr-x   1 root root 862632 Mar 30 00:16 xdg-desktop-portal-kde
 # equery b /usr/lib64/libexec
 * Searching for /usr/lib64/libexec ...
kde-frameworks/frameworkintegration-5.115.0 (/usr/lib64/libexec)
kde-frameworks/kauth-5.115.0 (/usr/lib64/libexec)
kde-frameworks/kcmutils-5.115.0 (/usr/lib64/libexec)
kde-frameworks/kconfig-5.115.0 (/usr/lib64/libexec)
kde-frameworks/kio-5.115.0 (/usr/lib64/libexec)
kde-frameworks/kxmlgui-5.115.0 (/usr/lib64/libexec)
kde-frameworks/purpose-5.115.0 (/usr/lib64/libexec)
kde-misc/kio-fuse-5.0.1_p20230130 (/usr/lib64/libexec)
kde-plasma/kde-cli-tools-5.27.11 (/usr/lib64/libexec)
kde-plasma/kscreenlocker-5.27.11 (/usr/lib64/libexec)
kde-plasma/kwayland-5.115.0 (/usr/lib64/libexec)
kde-plasma/libkscreen-5.27.11 (/usr/lib64/libexec)
kde-plasma/libksysguard-5.27.11 (/usr/lib64/libexec)
kde-plasma/polkit-kde-agent-5.27.11 (/usr/lib64/libexec)
kde-plasma/xdg-desktop-portal-kde-5.27.11 (/usr/lib64/libexec)
sys-libs/kpmcore-23.08.5 (/usr/lib64/libexec)
```

this looks wrong..
from https://api.kde.org/ecm/kde-module/KDEInstallDirs5.html
it looks like we need to be using 
LIBEXECDIR passed to cmake for these (or all kde?) builds..

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-04-02 05:11:19 UTC
This seems to go back a while? See e.g. bug 358945.
Comment 2 Gino McCarty 2024-06-01 21:08:01 UTC
whats going on with this? seems like the fix would need to be in the eclass?
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-06-01 21:09:21 UTC
I need asturm for this, sorry. I need to know what the history is and so on.
Comment 4 Gino McCarty 2024-06-01 21:26:48 UTC
thanks for responding so quickly

something like 

local mycmakeargs+=(
    KDE_INSTALL_FULL_LIBEXECDIR="${EPREFIX}/usr/libexec"
)
seems to be a variable in most framework CMAKELists.txt of course needs testing

hopefully someone has time on your team to at least confirm the bug.
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-06-03 00:16:48 UTC
Blocking bug 926828 for now as it would be a good time to do the transition, perhaps.
Comment 6 Greg Kubaryk 2024-06-03 00:26:22 UTC
(In reply to Gino McCarty from comment #4)
> hopefully someone has time on your team to at least confirm the bug.

Gentoo development doesn't really make much distinction between UNCONFIRMED and CONFIRMED; at one point in the past I think we talked about combining them into to OPEN - but I don't mind toggling it for aesthetics. :)
Comment 7 Andreas Sturmlechner gentoo-dev 2024-06-07 18:46:43 UTC
Default setting seems to come from here, and LIBDIR is where it gets it wrong for us:

https://invent.kde.org/frameworks/extra-cmake-modules/-/blob/master/kde-modules/KDEInstallDirsCommon.cmake?ref_type=heads#L251
Comment 8 Andreas Sturmlechner gentoo-dev 2024-06-07 21:43:54 UTC
Groundhog day.
Comment 9 Larry the Git Cow gentoo-dev 2024-06-12 15:29:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5487461e44bffc530ccbeba0867925d8658009d4

commit 5487461e44bffc530ccbeba0867925d8658009d4
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-06-02 20:36:21 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-06-12 15:25:05 +0000

    ecm.eclass: Pass -DKDE_INSTALL_LIBEXECDIR="${EPREFIX}/usr/libexec"
    
    But only in KF6-based packages as those are still masked, for getting
    away with changing installed files.
    
    Closes: https://bugs.gentoo.org/928345
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 eclass/ecm.eclass | 6 ++++++
 1 file changed, 6 insertions(+)
Comment 10 Larry the Git Cow gentoo-dev 2024-08-10 08:18:11 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8583678db11e3f57898839d741762c206f30a802

commit 8583678db11e3f57898839d741762c206f30a802
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2024-08-10 08:15:42 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2024-08-10 08:17:44 +0000

    kde-frameworks/kfilemetadata: Fix libexecdir path
    
    KDE-bug: https://bugs.kde.org/show_bug.cgi?id=491462
    
    Bug: https://bugs.gentoo.org/928345
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../files/kfilemetadata-6.5.0-libexecdir.patch     | 31 ++++++++++
 .../kfilemetadata/kfilemetadata-6.5.0-r1.ebuild    | 68 ++++++++++++++++++++++
 2 files changed, 99 insertions(+)