Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 928119 - Add new dev-db/redict package, fork of dev-db/redis
Summary: Add new dev-db/redict package, fork of dev-db/redis
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Anna
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-03-29 10:43 UTC by Yury Zhuravlev
Modified: 2024-04-23 14:50 UTC (History)
9 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Zhuravlev 2024-03-29 10:43:02 UTC
Because Redis Lab switched the BSD license to not open source, people made an LGPL fork - https://redict.io . It will be good to have this fork in the tree; it's 100% compatible with the original Redis for now. 
Currently, the BSD fork - Valkey, but Redict more mature was first. 

Reproducible: Always
Comment 1 Yury Zhuravlev 2024-03-29 11:27:55 UTC
In the future, I plan to replace Makefiles with Meson for Redict, and it should be much simpler to support.
Comment 2 Yury Zhuravlev 2024-03-29 12:28:26 UTC
The initial version of ebuild is ready https://github.com/stalkerg/gentoo/tree/redict/dev-db/redict  (jemalloc not working yet)

Also, I still use redis user and depend on acct-group/redis, acct-user/redis, sec-policy/selinux-redis probably I should prepared new packages.
Comment 3 Alfred Wingate 2024-03-29 14:45:20 UTC
https://redict.io/docs/redis-compat/package/

Redict upstream put out some documentation for downstream package maintainers.
Comment 4 Yury Zhuravlev 2024-03-31 08:01:58 UTC
Thanks, yes, I have to create a new user.
Comment 5 Haelwenn (lanodan) Monnier 2024-04-01 01:29:08 UTC
Also got a WIP version here, notably with some cleanups done.
From memory: Removing the configure.ac hack to entirely rely on toolchain.eclass, removing the obsolete sed for linenoise, and a config patch changed into a sed instead.

https://hacktivis.me/git/overlay/file/dev-db/redict/redict-9999.ebuild.html

Haven't tested jemalloc but tested it both on musl and glibc, could try to eventually repro+debug the jemalloc segfault but quite low priority for myself so far.
Comment 6 Larry the Git Cow gentoo-dev 2024-04-23 08:01:53 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/data/api.git/commit/?id=4709aa8be1d81c19f47fc47c66ce3fdfa05352f6

commit 4709aa8be1d81c19f47fc47c66ce3fdfa05352f6
Author:     Petr Vaněk <arkamar@gentoo.org>
AuthorDate: 2024-04-23 07:48:50 +0000
Commit:     Petr Vaněk <arkamar@gentoo.org>
CommitDate: 2024-04-23 08:01:37 +0000

    uid-gid: assign UID/GID 538 to dev-db/redict
    
    Bug: https://bugs.gentoo.org/928119
    See-also: https://github.com/gentoo/gentoo/pull/36176
    Signed-off-by: Petr Vaněk <arkamar@gentoo.org>

 files/uid-gid.txt | 1 +
 1 file changed, 1 insertion(+)
Comment 7 Larry the Git Cow gentoo-dev 2024-04-23 14:31:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b352f5973ac3936330344ab66a6b5da776d542d

commit 2b352f5973ac3936330344ab66a6b5da776d542d
Author:     Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
AuthorDate: 2024-04-17 23:52:18 +0000
Commit:     Petr Vaněk <arkamar@gentoo.org>
CommitDate: 2024-04-23 14:31:23 +0000

    dev-db/redict: new package, add 7.3.0
    
    Based on the redis 7.2.4-r1 ebuild. Without use of a custom
    configure.ac, and with aditional patches to make use of system
    packages for jemalloc and hiredict.
    
    Closes: https://bugs.gentoo.org/928119
    Signed-off-by: Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
    Closes: https://github.com/gentoo/gentoo/pull/36176
    Signed-off-by: Petr Vaněk <arkamar@gentoo.org>

 dev-db/redict/Manifest                             |   1 +
 dev-db/redict/files/redict-7.3.0-config.patch      |  40 ++++
 .../files/redict-7.3.0-system-hiredict.patch       | 240 +++++++++++++++++++++
 .../files/redict-7.3.0-system-jemalloc.patch       | 173 +++++++++++++++
 .../files/redict-sentinel-7.3.0-config.patch       |  27 +++
 dev-db/redict/files/redict-sentinel.confd          |  16 ++
 dev-db/redict/files/redict-sentinel.initd          |  22 ++
 dev-db/redict/files/redict.confd                   |  20 ++
 dev-db/redict/files/redict.initd                   |  25 +++
 dev-db/redict/files/redict.logrotate               |   6 +
 dev-db/redict/files/redict.service                 |  14 ++
 dev-db/redict/files/redict.tmpfiles                |   2 +
 dev-db/redict/metadata.xml                         |  20 ++
 dev-db/redict/redict-7.3.0.ebuild                  | 159 ++++++++++++++
 14 files changed, 765 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1475d9a56905e25efe4d027fd2b7f82cc94b2d02

commit 1475d9a56905e25efe4d027fd2b7f82cc94b2d02
Author:     Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
AuthorDate: 2024-04-18 00:05:18 +0000
Commit:     Petr Vaněk <arkamar@gentoo.org>
CommitDate: 2024-04-23 14:31:22 +0000

    acct-user/redict: new package, add 0
    
    While redict is meant to be a drop-in replacement for redis, it can run
    independetly of it or any other fork, with it's own paths for configs
    and state.
    
    And while all current forks are backwards compatible, they're not
    guaranteed to be forward compatible, while could lead to unexpected
    behaviour. Different users and groups for each fork minimize the space
    for data corruption.
    
    Signed-off-by: Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
    Bug: https://bugs.gentoo.org/928119
    Signed-off-by: Petr Vaněk <arkamar@gentoo.org>

 acct-user/redict/metadata.xml    | 12 ++++++++++++
 acct-user/redict/redict-0.ebuild | 11 +++++++++++
 2 files changed, 23 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ea1376a25ac13ca5775014a1857318b9654179c3

commit ea1376a25ac13ca5775014a1857318b9654179c3
Author:     Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
AuthorDate: 2024-04-18 00:05:36 +0000
Commit:     Petr Vaněk <arkamar@gentoo.org>
CommitDate: 2024-04-23 14:31:21 +0000

    acct-group/redict: new package, add 0
    
    Signed-off-by: Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
    Bug: https://bugs.gentoo.org/928119
    Signed-off-by: Petr Vaněk <arkamar@gentoo.org>

 acct-group/redict/metadata.xml    | 12 ++++++++++++
 acct-group/redict/redict-0.ebuild |  9 +++++++++
 2 files changed, 21 insertions(+)
Comment 8 Larry the Git Cow gentoo-dev 2024-04-23 14:50:33 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ab60e7a03b46ccf54a94af3a25f7610dab25ab9c

commit ab60e7a03b46ccf54a94af3a25f7610dab25ab9c
Author:     Petr Vaněk <arkamar@gentoo.org>
AuthorDate: 2024-04-23 14:48:28 +0000
Commit:     Petr Vaněk <arkamar@gentoo.org>
CommitDate: 2024-04-23 14:48:28 +0000

    dev-db/redict: Update copyright header in run scripts
    
    Bug: https://bugs.gentoo.org/928119
    Signed-off-by: Petr Vaněk <arkamar@gentoo.org>

 dev-db/redict/files/redict-sentinel.initd | 2 +-
 dev-db/redict/files/redict.initd          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)