1) The ebuild currently has a large number of seds. seds are generally undesirable because they fail silently (e.g. they stop doing anything, or they stop changing everything you thought they were, or they start changing the wrong thing). Patches have the advantage of telling you when they stop applying. Also, seds can't be upstreamed, of course. A patch can be. Have any of these been sent upstream? 2) The eselect-pinentry dep should probalby be IDEPEND. 3) --disable-static can be dropped, as it's the default w/ EAPI 8. 4) See bug 928091. 5) pkgconfig belongs in BDEPEND, not DEPEND, as it is executed.
(In reply to Sam James from comment #0) > 1) The ebuild currently has a large number of seds. > > seds are generally undesirable because they fail silently (e.g. they stop > doing anything, or they stop changing everything you thought they were, or > they start changing the wrong thing). Patches have the advantage of telling > you when they stop applying. > > Also, seds can't be upstreamed, of course. A patch can be. > > Have any of these been sent upstream? I forked 'upstream' repo, applied sed and filed a pull request. Actually, I filed several pull requests upstream. All (except one) were merged. So I was able to remove several seds. The remaining seds are more related to Portage merge and less to the overall eid-mw project. > 2) The eselect-pinentry dep should probalby be IDEPEND. I don't understand why you say that : I did not set eselect-pinentry dependency but app-crypt/pinentry in RDEPEND as several other packages in portage tree. > 3) --disable-static can be dropped, as it's the default w/ EAPI 8. OK done > 4) See bug 928091. Answer later at bug 928091 > 5) pkgconfig belongs in BDEPEND, not DEPEND, as it is executed. Right : done The fixes explained above are recently applied to the current live ebuild in portage tree. Take a look at current live ebuild. Can i close this bug or should i wait the commit of new mainstream version ?
FYI : one of the pull request was reverted: see also https://github.com/Fedict/eid-mw/pull/199
