Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927993 - dev-libs/libfido2-1.14.0: version bump with added use flag pcsc-lite (ebuild attached)
Summary: dev-libs/libfido2-1.14.0: version bump with added use flag pcsc-lite (ebuild ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-03-27 22:02 UTC by Erik Quaeghebeur
Modified: 2024-12-01 17:17 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated ebuild (libfido2-1.14.0.ebuild,1.14 KB, application/vnd.gentoo.ebuild)
2024-03-27 22:02 UTC, Erik Quaeghebeur
Details
updated metadata (metadata.xml,492 bytes, text/xml)
2024-03-27 22:02 UTC, Erik Quaeghebeur
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Erik Quaeghebeur 2024-03-27 22:02:14 UTC
Created attachment 888853 [details]
updated ebuild

I needed libfido2 tools with pcsc support. Therefore, I created an updated ebuild for the latest release with this functionality included behind a use flag pcsc-lite (the package pulled in, as also used by other packages). I've tested it, and the pcsc functionality I used seemed to work as expected.

I'm attaching the updated ebuild and metadata files. (Sorry for not going the git-format patch route, but the way I created the ebuild seems to make that difficult.) The package is also available through my overlay <https://github.com/equaeghe/gentoo-overlay/tree/master/dev-libs/libfido2>.

Signed-off-by: Erik Quaeghebeur <gentoo@e3q.eu>
Comment 1 Erik Quaeghebeur 2024-03-27 22:02:43 UTC
Created attachment 888854 [details]
updated metadata
Comment 2 Matthias Maier gentoo-dev 2024-04-16 04:10:49 UTC
I second this request.
Comment 3 Christopher Byrne 2024-07-19 00:17:21 UTC
I this request and have submitted a PR for the current version (1.15.0)
Comment 4 Larry the Git Cow gentoo-dev 2024-12-01 14:20:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=81ea7d0f44315a54e4d885655f8635c4635d241c

commit 81ea7d0f44315a54e4d885655f8635c4635d241c
Author:     Christopher Byrne <salah.coronya@gmail.com>
AuthorDate: 2024-07-18 16:04:53 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-01 14:18:06 +0000

    dev-libs/libfido2: add 1.15.0
    
    Closes: https://bugs.gentoo.org/927993
    Signed-off-by: Christopher Byrne <salah.coronya@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/libfido2/Manifest               |  1 +
 dev-libs/libfido2/libfido2-1.15.0.ebuild | 68 ++++++++++++++++++++++++++++++++
 dev-libs/libfido2/metadata.xml           |  1 +
 3 files changed, 70 insertions(+)
Comment 5 Erik Quaeghebeur 2024-12-01 17:11:00 UTC
(In reply to Larry the Git Cow from comment #4)
> The bug has been closed via the following commit(s):
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/
> ?id=81ea7d0f44315a54e4d885655f8635c4635d241c
> 
> commit 81ea7d0f44315a54e4d885655f8635c4635d241c
> Author:     Christopher Byrne <salah.coronya@gmail.com>
> AuthorDate: 2024-07-18 16:04:53 +0000
> Commit:     Sam James <sam@gentoo.org>
> CommitDate: 2024-12-01 14:18:06 +0000
> 
>     dev-libs/libfido2: add 1.15.0
>     
>     Closes: https://bugs.gentoo.org/927993
>     Signed-off-by: Christopher Byrne <salah.coronya@gmail.com>
>     Signed-off-by: Sam James <sam@gentoo.org>
> 
>  dev-libs/libfido2/Manifest               |  1 +
>  dev-libs/libfido2/libfido2-1.15.0.ebuild | 68
> ++++++++++++++++++++++++++++++++
>  dev-libs/libfido2/metadata.xml           |  1 +
>  3 files changed, 70 insertions(+)

The following is in the 1.15 ebuild:

```
-DUSE_PCSC=$(usex smartcard pcsc-lte)
```

Is that correct?

(I had, in my 1.14 ebuild,

```
-DUSE_PCSC=$(usex pcsc-lite)
```

where my 1.14 use flag was called pcsc-lite and the 1.15 one is called smartcard

)

Also, the metadata line 

```
<flag name="pcsc-lite">Enable smartcard support with sys-apps/pcsc-lite</flag>
```

does not seem to have been added, as

```
<flag name="smartcard">Enable smartcard support with sys-apps/pcsc-lite</flag>
```

Finally, also for the metadata, NFC support does not seem to be experimental anymore <https://github.com/Yubico/libfido2?tab=readme-ov-file#build-time-customisation>.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-12-01 17:15:27 UTC
smartcard is a global USE flag so no need for a local description unless it would provide some useful detail or clarity.

As for pcsc-lte, yeah, that's a typo. I'll fix it.
Comment 7 Larry the Git Cow gentoo-dev 2024-12-01 17:17:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2e5adefb8be0d06d57f52250ba1603520b296a67

commit 2e5adefb8be0d06d57f52250ba1603520b296a67
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-12-01 17:16:01 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-12-01 17:17:06 +0000

    dev-libs/libfido2: fix usex typo
    
    Bug: https://bugs.gentoo.org/927993
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/libfido2/{libfido2-1.15.0.ebuild => libfido2-1.15.0-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)