Created attachment 888767 [details, diff] Add missing headers for MOZ_TRY to intl/components/src/TimeZone.h Currently, firefox[system-icu] requires firefox[jumbo-build]. This exists primarily since MOZ_TRY isn't available in non-unity build env. The issue stems from a lack of `#include "mozilla/Try.h"` in TimeZone.cpp (or its included headers) The attached patch allows for non-unified builds even w/ [system-icu] enabled. We simply include the relevant header in TimeZone.h, which in turn is included by TimeZone.cpp. Including this header has no-impact on unity builds either.
Created attachment 888909 [details, diff] bmo#1882942: add missing header for size_t
Created attachment 888910 [details, diff] Add missing headers for MOZ_TRY to intl/components/src/TimeZone.h
Created attachment 888911 [details, diff] GtkCompositorWidget.h: add missing header for GdkIsWaylandDisplay in non-unified builds
Created attachment 888912 [details, diff] accessible/html/{HTMLSelectAccessible,HTMLTableAccessible}.cpp: add missing header DocAccessible-inl.h for non-unified builds
Added additional [4/4] patches needed for non-jumbo builds
hi, are these patches written by you? If this is the case, please upstream them via https://bugzilla.mozilla.org/ the gentoo mozilla team usually only adds patches to the gentoo patchset if they have landed in nightly, so if you can get them merged into nightly it will most likely be possible to add them.
W/ the exception of the size_t patch, all other patches are indeed fresh. Will try to submit to bmo/phabricator, but not sure iirc non-unity builds are a non-goal.
you should file a bug through the bugzilla first, it will connect you to the mozilla devs who are interested into non-unified builds. your patches will get reviewed much faster, in my experience with them in the past.
Filed upstream issue @ bmo#1889054
Thanks for the patches and an upstream bug! I'll try to test these.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7bcd75e0392bf8a0a14d444be7c6b842d1076597 commit 7bcd75e0392bf8a0a14d444be7c6b842d1076597 Author: Joonas Niilola <juippis@gentoo.org> AuthorDate: 2024-04-05 14:17:03 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2024-04-05 14:18:26 +0000 www-client/firefox: include patch to fix jumbo-build + system-icu woes Closes: https://bugs.gentoo.org/927958 Signed-off-by: Joonas Niilola <juippis@gentoo.org> www-client/firefox/Manifest | 2 +- www-client/firefox/firefox-124.0.2.ebuild | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)
