Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927833 - media-libs/embree-4.3.0: still slotted to 3
Summary: media-libs/embree-4.3.0: still slotted to 3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Sebastian Parborg
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-03-25 21:38 UTC by Ada
Modified: 2024-04-02 11:29 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ada 2024-03-25 21:38:55 UTC
embree 4 changed include paths from "embree3" to "embree4", as such things that require embree 3 will fail despite using slot 3 (such as dev-games/godot with USE="gui raycast")

I believe embree 4 is safe to slot to 4 as there are no file collisions.

Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2024-03-26 05:52:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d918b34514f1d01c2a1df5e1837dbfc4d225b723

commit d918b34514f1d01c2a1df5e1837dbfc4d225b723
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2024-03-26 05:02:10 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2024-03-26 05:51:07 +0000

    profiles: mask media-libs/embree-4 for now
    
    Did give it a quick try with minimal USE and (as noted in the bug)
    embree3 and 4 do coexist without any changes and seems to me they
    are indeed meant to be treated like a different SLOT or package.
    
            /usr/lib64/libembree3.so
            /usr/lib64/libembree4.so
            /usr/include/embree3
            /usr/include/embree4
    
    (either way the soname changed, *if* not slotted it'd need a subslot)
    
    Revdeps may need attention to depend on specific slot and select
    properly if they can use either (assume blender does automagic?
    currently does not depend on >=4 anyhow) so just doing a quick
    mask until this is properly looked at.
    
    Godot already depend explicitly on embree:3. If *really* had to
    it could optionally switch to bundled embree rather than set
    an upper bound if not slotted (or when :3 is to be removed).
    
    Bug: https://bugs.gentoo.org/927833
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 2 Larry the Git Cow gentoo-dev 2024-04-02 11:29:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5c2ef969d489dc220f6001c228cd7b9367a77f03

commit 5c2ef969d489dc220f6001c228cd7b9367a77f03
Author:     Paul Zander <negril.nx+gentoo@gmail.com>
AuthorDate: 2024-03-26 14:06:11 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-04-02 11:26:47 +0000

    media-libs/embree: 4.3.1 bump, fix slot, remove mask, re-enable tests
    
    Split up REQUIRED_USE per arch.
    
    Closes: https://bugs.gentoo.org/927843
    Closes: https://bugs.gentoo.org/927833
    Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/35927
    Signed-off-by: Sam James <sam@gentoo.org>

 media-gfx/blender/blender-3.3.15.ebuild            |  2 +-
 media-gfx/blender/blender-3.3.6-r1.ebuild          |  2 +-
 media-gfx/blender/blender-3.3.8.ebuild             |  2 +-
 media-gfx/blender/blender-3.6.0.ebuild             |  2 +-
 media-gfx/blender/blender-3.6.5.ebuild             |  2 +-
 media-gfx/blender/blender-3.6.8.ebuild             |  2 +-
 media-gfx/blender/blender-4.0.1-r1.ebuild          |  2 +-
 media-gfx/blender/blender-4.0.2.ebuild             |  2 +-
 media-gfx/blender/blender-9999.ebuild              |  2 +-
 media-libs/embree/Manifest                         |  2 +-
 .../{embree-4.3.0.ebuild => embree-4.3.1.ebuild}   | 54 ++++++++++++++++++++--
 ...h => embree-4.3.1-dont-install-tutorials.patch} | 13 ++----
 media-libs/openpgl/openpgl-0.5.0.ebuild            |  2 +-
 profiles/package.mask                              |  5 --
 14 files changed, 63 insertions(+), 31 deletions(-)