Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927402 - sys-fs/lvm2 uses /sbin/thin_check, but thin_provisioning-tools installs in /usr/sbin/
Summary: sys-fs/lvm2 uses /sbin/thin_check, but thin_provisioning-tools installs in /u...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-21 14:00 UTC by Ed Wildgoose
Modified: 2024-05-02 14:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Wildgoose 2024-03-21 14:00:00 UTC
This feels like such a big issue that I initially suspect some error in my config, however, after upgrading to sys-fs/lvm2-2.03.22-r3 my thin volumes no longer mount. Issue is that the /etc/init.d/lvm2 script fails with:



This seems to be down to the following stanza in the ebuild:

    if use lvm && use thin; then
        myeconfargs+=( --with-thin=internal --with-cache=internal )
        local texec
        for texec in check dump repair restore; do
            myeconfargs+=( --with-thin-${texec}="${EPREFIX}"/sbin/thin_${texec} )
            myeconfargs+=( --with-cache-${texec}="${EPREFIX}"/sbin/cache_${texec} )
        done
    else
        myeconfargs+=( --with-thin=none --with-cache=none )
    fi

Here we seem to be forcing the autoconf values for "--with-thin-check=/sbin/thing_check"

However, current sys-block/thin-provisioning-tools-1.0.10 installs the tools into /usr/sbin/

This seems like it could cause boot failures for others?
Comment 1 Ed Wildgoose 2024-03-21 14:02:46 UTC
Oops. Missed pasting in the init.d errors. 

# /etc/init.d/lvm restart
lvm                       | * WARNING: you are stopping a boot service
lvm                       | * Caching service dependencies ...                                                                                                                                                                                [ ok ]
lvm                       | * Stopping the Logical Volume Manager ...
lvm                       |  /sbin/thin_check: execvp failed: No such file or directory
lvm                       |  WARNING: Check is skipped, please install recommended missing binary /sbin/thin_check!
lvm                       |  0 logical volume(s) in volume group "vg_slow" now active                                                                                                                                                         [ ok ]
lvm                       | * Starting the Logical Volume Manager ...
lvm                       |  Found volume group "vg_slow" using metadata type lvm2
lvm                       |  /sbin/thin_check: execvp failed: No such file or directory
lvm                       |  WARNING: Check is skipped, please install recommended missing binary /sbin/thin_check!
lvm                       |  1 logical volume(s) in volume group "vg_slow" now active
Comment 2 Larry the Git Cow gentoo-dev 2024-05-02 14:55:17 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=449dc37ae3fbdefc9bc3453c0b7ba50971f2876b

commit 449dc37ae3fbdefc9bc3453c0b7ba50971f2876b
Author:     Mike Gilbert <floppym@gentoo.org>
AuthorDate: 2024-05-02 14:53:13 +0000
Commit:     Mike Gilbert <floppym@gentoo.org>
CommitDate: 2024-05-02 14:53:13 +0000

    sys-fs/lvm2: update path for thin-provisioning-tools
    
    The rust-based package installs binaries in /usr/sbin.
    
    Closes: https://bugs.gentoo.org/927402
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

 sys-fs/lvm2/{lvm2-2.03.22-r3.ebuild => lvm2-2.03.22-r4.ebuild} | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)