Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927336 - media-sound/denemo-2.6.0-r3 fails to compile: sffile.c:38:10: error: implicit declaration of function isprint [-Wimplicit-function-declaration]
Summary: media-sound/denemo-2.6.0-r3 fails to compile: sffile.c:38:10: error: implicit...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Bernd
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks: c99-porting gcc-14-stable
  Show dependency tree
 
Reported: 2024-03-20 08:59 UTC by Agostino Sarubbo
Modified: 2024-11-27 04:53 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,158.37 KB, text/plain)
2024-03-20 08:59 UTC, Agostino Sarubbo
Details
Patch fixing isprint and a missing declaration in libs/libsffile/sffile.c as well as a type mismatch in src/source/proof.c (isprint.patch,2.25 KB, patch)
2024-09-03 14:17 UTC, Bernd Feige
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-03-20 08:59:15 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-sound/denemo-2.6.0-r3 fails to compile.
Discovered on: x86 (internal ref: tinderbox_x86)
System: GCC-14-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-14)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0002
Comment 1 Agostino Sarubbo gentoo-dev 2024-03-20 08:59:16 UTC
Created attachment 887975 [details]
build.log

build log and emerge --info
Comment 2 Bernd Feige 2024-09-03 14:17:35 UTC
Created attachment 901956 [details, diff]
Patch fixing isprint and a missing declaration in libs/libsffile/sffile.c as well as a type mismatch in src/source/proof.c

Attached my changes to make denemo compile on an up-to-date gentoo (~amd64) system:

- The "isprint" declaration only needs an "#include <ctype.h>" in libs/libsffile/sffile.c.

- There is also a line "static initialized = FALSE;" on which current compilers choke; Add the type "int".

- In src/source/proof.c the compilation fails because an "EvDocument *doc" is passed as first argument of ev_document_annotations_get_annotations() but this function expects an "EvDocumentAnnotations *". The dummy declarations of ev_document_annotations_get_annotations() present in the source indicate that previously no declarations were included in evince-document.h - now they are.
This is for current app-text/evince-46.3.

I did download current head denemo-2.6.39 hoping that these issues would be fixed there, but only "static initialized = FALSE;" is fixed there and other issues added that I did not pursue.
Comment 3 Larry the Git Cow gentoo-dev 2024-09-18 13:12:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dc3e2348609b3c156dd9e06aba46be5f7b69fefb

commit dc3e2348609b3c156dd9e06aba46be5f7b69fefb
Author:     Alfred Wingate <parona@protonmail.com>
AuthorDate: 2024-08-27 18:10:44 +0000
Commit:     Arsen Arsenović <arsen@gentoo.org>
CommitDate: 2024-09-18 13:06:42 +0000

    media-sound/denemo: switch to new guile mechanism
    
    Bug: https://bugs.gentoo.org/927336
    Signed-off-by: Alfred Wingate <parona@protonmail.com>
    Signed-off-by: Arsen Arsenović <arsen@gentoo.org>

 media-sound/denemo/denemo-2.6.0-r100.ebuild        | 136 +++++++++++++++++++++
 .../denemo/files/denemo-2.6.0-fix-c99.patch        |  38 ++++++
 .../files/denemo-2.6.0-incompatible-pointers.patch |  36 ++++++
 profiles/package.mask                              |   1 +
 4 files changed, 211 insertions(+)
Comment 4 Andreas K. Hüttel archtester gentoo-dev 2024-10-24 13:32:55 UTC
Is this fixed in -r100 ?
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-11-27 04:53:30 UTC
yes, it should be