Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927237 - app-metrics/node_exporter-0.17.0-r1 crashes right after start
Summary: app-metrics/node_exporter-0.17.0-r1 crashes right after start
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: William Hubbs
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-03-18 11:44 UTC by Ferdinand Kuhl
Modified: 2024-03-25 02:54 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ferdinand Kuhl 2024-03-18 11:44:15 UTC
After the update of node_exporter the services crashes immediately after restart. It complains in logs with the following error:

node_exporter: error: flag 'collector.textfile.directory' cannot be repeated, try --help

This originates from the /etc/conf.d/ provided by portage itself:

########## portage/app-metrics/node_exporter/files/node_exporter.confd ##########
# arguments for prometheus node exporter
command_args="--collector.textfile.directory=/var/lib/node_exporter/ --collector.textfile.directory=/var/lib/node_exporter"
########## portage/app-metrics/node_exporter/files/node_exporter.confd ##########

So the default is not able to start on its own - one of the arguments needs to be dropped.
Comment 1 Larry the Git Cow gentoo-dev 2024-03-25 02:54:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=93b6d4d786d44bb144e4b766181a46a28f0c8e19

commit 93b6d4d786d44bb144e4b766181a46a28f0c8e19
Author:     Rahil Bhimjiani <me@rahil.rocks>
AuthorDate: 2024-03-18 20:01:35 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2024-03-25 02:54:39 +0000

    app-metrics/node_exporter: fix 1.7.0-r1 and rev-bump to r2
    
    I can't remember how did this happen. Maybe I blindly just added args to
    .service unit and confd without checking if it was needed.
    
    Closes: https://bugs.gentoo.org/927237
    Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
    Closes: https://github.com/gentoo/gentoo/pull/35822
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 app-metrics/node_exporter/files/node_exporter.confd                     | 2 +-
 .../{node_exporter-1.7.0-r1.ebuild => node_exporter-1.7.0-r2.ebuild}    | 0
 2 files changed, 1 insertion(+), 1 deletion(-)