Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927212 - media-libs/libdv-1.0.0-r4 fails to compile: dv.c:224:90: error: passing argument 5 of _dv_quant_88_inverse_x86 from incompatible pointer type [-Wincompatible-pointer-types]
Summary: media-libs/libdv-1.0.0-r4 fails to compile: dv.c:224:90: error: passing argum...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Media-video project
URL:
Whiteboard: patch
Keywords:
Depends on:
Blocks: c99-porting gcc-14-stable
  Show dependency tree
 
Reported: 2024-03-17 20:37 UTC by Agostino Sarubbo
Modified: 2024-10-24 13:31 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,64.98 KB, text/plain)
2024-03-17 20:37 UTC, Agostino Sarubbo 		Details
Fixes the incompatible pointer type in quant.c (quant.c.diff,467 bytes, patch)
2024-09-17 01:19 UTC, Nuitari 		Details | Diff
Untested patch that fixes the build errors (quant.patch,1.15 KB, patch)
2024-10-20 01:27 UTC, Kaukov 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-03-17 20:37:57 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-libs/libdv-1.0.0-r4 fails to compile.
Discovered on: x86 (internal ref: tinderbox_x86)
System: GCC-14-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-14)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0003
Comment 1 Agostino Sarubbo gentoo-dev 2024-03-17 20:37:58 UTC 
Created attachment 887854 [details]
build.log

build log and emerge --info
Comment 2 Michael Cook 2024-07-19 17:46:38 UTC 
https://koji.fedoraproject.org/koji/buildinfo?buildID=2496481

Fedora did update the libdv-pic patch which is rather old (#121871)

https://bugzilla.redhat.com/show_bug.cgi?id=2261310 relevant RHBZ
Comment 3 Nuitari 2024-09-17 01:19:59 UTC 
Created attachment 903168 [details, diff]
Fixes the incompatible pointer type in quant.c

The RH patch was missing the fix for quant.c, I've attached mine here. It compiles, but I don't have a way of testing it. 

Signed-off-by: Stephane Bakhos <nuitari@nuitari.net>
Comment 4 Kaukov 2024-10-20 01:27:36 UTC 
Created attachment 906393 [details, diff]
Untested patch that fixes the build errors

A patch based on the above suggestions. Fixes the build errors, but I'm not sure of the actual performance/feature impact.

I had to add 2 more changes to `dv.c` as it also had build errors due to the same issue.