Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927027 - dev-libs/json-c-0.17 tests fails if valgrind isn't installed
Summary: dev-libs/json-c-0.17 tests fails if valgrind isn't installed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Jakov Smolić
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-14 15:25 UTC by REVOL V.
Modified: 2024-03-16 05:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description REVOL V. 2024-03-14 15:25:56 UTC
This package requires valgrind for it's test if this env variable isn't set like this: USE_VALGRIND=0

Reproducible: Always

Steps to Reproduce:
1. (Only if applicable) Unmerge valgrind
2. emerge dev-libs/json-c with FEATURES containing 'test'
3. Stare at error message
Actual Results:  
package not emerged and all 25 test failed.

Expected Results:  
Package emerged sucessfully either by requiring a dependency on Valgrind or by setting the env variable disabling valgrind

The README file explain the fix with env variable.


Minor because it's easy to pass the variable to emerge
Comment 1 Larry the Git Cow gentoo-dev 2024-03-16 05:23:41 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=acc020e3ee4ade729f99d49d5ee43f90a8d510e1

commit acc020e3ee4ade729f99d49d5ee43f90a8d510e1
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2024-03-16 05:22:30 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-16 05:23:11 +0000

    dev-libs/json-c: don't use Valgrind automagically in tests
    
    Closes: https://bugs.gentoo.org/927027
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/json-c/json-c-0.17.ebuild | 5 ++++-
 dev-libs/json-c/json-c-9999.ebuild | 3 +++
 2 files changed, 7 insertions(+), 1 deletion(-)