Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 927012 - x11-terms/kitty-0.33.0: Please add -buildvcs=false to GOFLAGS
Summary: x11-terms/kitty-0.33.0: Please add -buildvcs=false to GOFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Ionen Wolkens
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-14 09:50 UTC by Bernd Feige
Modified: 2024-03-14 10:00 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd Feige 2024-03-14 09:50:41 UTC
I'm one of the people regularly bitten by build systems searching for VCS files outside the build directory, as I have directories above the build directories under version control, resulting in a sandbox violation error. Error or not, the gentoo build does not run in a git checkout by default, so the VCS search will always leave the sandbox and will always be a security risk.

In response to https://bugs.gentoo.org/836261 "-buildvcs=false" was added to default GOFLAGS in go-module.eclass. The kitty ebuild uses go-env.eclass however without default GOFLAGS.

It works for me to just add "-buildvcs=false" on line 135:

local -x GOFLAGS="-p=$(makeopts_jobs) -v -x -buildvcs=false"

Reproducible: Always
Comment 1 Ionen Wolkens gentoo-dev 2024-03-14 09:53:56 UTC
Sure

Note odds are will switch to go-module.eclass sometime after bug #926841, so these defaults will sync up -- but no harm in adding this meanwhile.
Comment 2 Larry the Git Cow gentoo-dev 2024-03-14 10:00:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=322e5186606b64ef16907668bc914e65c2ab951a

commit 322e5186606b64ef16907668bc914e65c2ab951a
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2024-03-14 09:58:11 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2024-03-14 09:59:04 +0000

    x11-terms/kitty: pass -buildvcs=false
    
    Closes: https://bugs.gentoo.org/927012
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 x11-terms/kitty/kitty-0.32.2.ebuild | 2 +-
 x11-terms/kitty/kitty-0.33.0.ebuild | 2 +-
 x11-terms/kitty/kitty-9999.ebuild   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)