Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 926655 - <app-text/bibletime-3.1.0 depends on dev-qt/qtwebengine:5
Summary: <app-text/bibletime-3.1.0 depends on dev-qt/qtwebengine:5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL: https://github.com/bibletime/bibletim...
Whiteboard:
Keywords: PMASKED, PullRequest
Depends on:
Blocks: qtwebengine5-removal
  Show dependency tree
 
Reported: 2024-03-10 08:46 UTC by Andreas Sturmlechner
Modified: 2025-02-16 10:51 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
9999 ebuild working with QT5 without webengine (bibletime-9999.ebuild,1.68 KB, application/vnd.gentoo.ebuild)
2025-01-24 15:26 UTC, genBTC
Details
bibletime-3.1.0_rc2.ebuild -DUSE_QT6=on (bibletime-3.1.0_rc2.ebuild,1.58 KB, application/vnd.gentoo.ebuild)
2025-02-12 18:26 UTC, genBTC
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2024-03-10 08:46:45 UTC
master is already able to be built with Qt6 and even dropped qt5compat:6 dependency already.
Comment 1 Larry the Git Cow gentoo-dev 2025-01-22 23:28:25 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6ae8a555661225c096d47b1c559fa063832b2ca5

commit 6ae8a555661225c096d47b1c559fa063832b2ca5
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2025-01-22 23:27:45 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-01-22 23:28:14 +0000

    profiles: Mask app-text/bibletime for removal
    
    Bug: https://bugs.gentoo.org/926655
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 2 Nicolas PARLANT 2025-01-23 10:21:57 UTC
Argh, I had one in local that I didn't push (https://github.com/gentoo/gentoo/commit/51f0f72f3140d7e354e7bfcb820f788a05e061b7).
But I think you need more a maintainer than an ebuild
Comment 3 Andreas Sturmlechner gentoo-dev 2025-01-23 19:27:23 UTC
Yes, this should really get a dedicated maintainer actually using it themselves. That person has a few weeks left to step up.
Comment 4 genBTC 2025-01-24 15:22:38 UTC
After looking into and putting some effort into this, the qtwebengine dep can be dropped entirely.
I've just built a bibletime-9999 using QT5, NO webengine installed or required. (uploading ebuild as an attachment to follow)
Browsing the codebase, returns no more mention of webengine or webkit.
I can't locate what feature requested webengine, its a regular desktop app.

Also the cmake build supports passing -DUSE_QT6=ON to turn it all into a QT6 program (as shown in the user ebuild Nicolas just linked)

we can save this, and I can do more if needed.
Comment 5 genBTC 2025-01-24 15:26:58 UTC
Created attachment 917403 [details]
9999 ebuild working with QT5 without webengine

1) this version changed a couple DEPENDS, no webengine no webchannel. QA requested to add declarative. cmake file seems to request quickcontrols.
2) also had to update the .desktop cache.
3) Docs - Changelog no longer exists.
Comment 6 Nicolas PARLANT 2025-01-24 15:50:35 UTC
(In reply to genBTC from comment #4)
> After looking into and putting some effort into this, the qtwebengine dep
> can be dropped entirely.

2018 .... :
https://github.com/bibletime/bibletime/commit/4a71e777248976dc748b0331ac7edb3e671a1b96
Comment 7 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-01-24 15:53:43 UTC
We can probably keep it if you can give it a good polish now and hopefully put it in good stead for the future.
Comment 8 Nicolas PARLANT 2025-01-24 16:05:56 UTC
@genBTC cherry-pick that one without webengine+xdg+locales
https://github.com/gentoo/gentoo/commit/8ce89ed7567d
Otherwise I can maintain it for guru.
Comment 9 Andreas Sturmlechner gentoo-dev 2025-02-02 12:15:47 UTC
(In reply to genBTC from comment #4)
> we can save this, and I can do more if needed.
Would you like to proxy-maintain it?
Comment 10 Jaak Ristioja 2025-02-10 21:00:10 UTC
BibleTime 3.1.0 RC2 has just been released with Qt6 support:

https://github.com/bibletime/bibletime/releases/tag/v3.1.0_rc2
Comment 11 Nicolas PARLANT 2025-02-11 12:01:38 UTC
When do you plan to release the final version?

It would be annoying to treeclean.
Comment 12 Jaak Ristioja 2025-02-11 17:43:19 UTC
We're planning to release the final version before treecleaning. :) I'm currently aiming for approximately February 17th, but it would help if you can give me a more accurate deadline to dodge treecleaning.
Comment 13 Nicolas PARLANT 2025-02-11 18:44:22 UTC
Please, do not rush a release for gentoo.

Andreas, could you revert last rite ? :
- package finally don't required qtwebengine
- upstream does efforts and have repo (see  https://cgit.gentoo.org/user/bibletime.git/ and https://github.com/bibletime/bibletime/issues/491)

Jaak Ristioja, why not be proxy-maintainer of your project ? Furthermore, bugs from gentoo are still useful for upstream.
Comment 14 Andreas Sturmlechner gentoo-dev 2025-02-11 18:49:39 UTC
last-rites are seldomly set in stone. this one was triggered by qtwebengine:5 removal, but really emphasizes on this package getting a dedicated maintainer.
Comment 15 Andreas Sturmlechner gentoo-dev 2025-02-11 20:46:22 UTC
(In reply to genBTC from comment #4)
> Also the cmake build supports passing -DUSE_QT6=ON to turn it all into a QT6
> program (as shown in the user ebuild Nicolas just linked)
If it does that, then your ebuild should have been Qt6 based, so it could have been used for 3.1.0 RC2. ;)
Comment 16 genBTC 2025-02-12 17:54:48 UTC
Right, ill work on the QT6 ebuild now that rc's are here.
Comment 17 genBTC 2025-02-12 18:26:59 UTC
Created attachment 918857 [details]
bibletime-3.1.0_rc2.ebuild -DUSE_QT6=on

bibletime-3.1.0_rc2.ebuild latest RC builds successfully, QT6, no webengine, deps double checked, l10n doc support contribution from Nicolas.
Comment 18 genBTC 2025-02-12 18:40:03 UTC
In the issue over on github, the dev jaak raised two final bugs:
https://github.com/bibletime/bibletime/issues/491#issuecomment-2651535446
and By RC3 both will be fixed.
They are maintaining their own overlay with the ebuild so they probably know best,
https://cgit.gentoo.org/user/bibletime.git/tree/app-text/bibletime
Comment 19 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2025-02-12 18:41:46 UTC
They've been asked above if they want to proxy-maintain it (hopefully they do).
Comment 20 Andreas Sturmlechner gentoo-dev 2025-02-12 18:44:42 UTC
Regarding the potential procedure: Last-rites can be stopped, but I'd suggest leaving the mask in place, just version restricted, and simply add an ~arch only Qt6 bump.
Comment 21 Jaak Ristioja 2025-02-12 19:40:49 UTC
(In reply to Nicolas PARLANT from comment #13)
> Jaak Ristioja, why not be proxy-maintainer of your project ? Furthermore,
> bugs from gentoo are still useful for upstream.
Yes, I'm thankful for the bug reports. Unfortunately, as I'm already struggling to maintain BibleTime, I can't commit to being a proxy-maintainer at this time.

(In reply to genBTC from comment #18)
> In the issue over on github, the dev jaak raised two final bugs:
> https://github.com/bibletime/bibletime/issues/491#issuecomment-2651535446
> and By RC3 both will be fixed.
To make things easier for you, I hope to release RC3 in the next few hours.

> They are maintaining their own overlay with the ebuild so they probably know
> best,
> https://cgit.gentoo.org/user/bibletime.git/tree/app-text/bibletime
Nah, my ebuilds are not as good as yours.

However, I think the fix to the *.desktop file included in your ebuild is incorrect. The Freedesktop.org Desktop Menu Specification (version 1.1) section 3 states[1]:

> Desktop entries should list all categories that clearly apply. They should not list categories that only vaguely or possibly apply, because the user will end up seeing the same desktop entry in a half-dozen places.
In my opinion the new categories added by your ebuild apply vaguely. According to appendix A.2 [2] such "Related Categories" are only "suggested" to be used in conjunction with the respective "Additional Category".

[1]: https://specifications.freedesktop.org/menu-spec/latest/desktop-entry-extensions.html
[2]: https://specifications.freedesktop.org/menu-spec/latest/additional-category-registry.html
Comment 22 Nicolas PARLANT 2025-02-13 06:45:46 UTC
genBTC, you have not yet answered THE question ;-).

I just launched BT and found a dual display (or more) of old translations, with the Bailly dictionnary add-on. This application has a new interest for me as study support (translation old greek).
Can be the proxy-maintainer if you agree.
Comment 23 Larry the Git Cow gentoo-dev 2025-02-14 13:07:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a612286a320b95f38a7eb8a4105b3c6ba8100677

commit a612286a320b95f38a7eb8a4105b3c6ba8100677
Author:     Nicolas PARLANT <nicolas.parlant@parhuet.fr>
AuthorDate: 2025-01-13 13:15:39 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-02-14 13:06:47 +0000

    app-text/bibletime: add 3.1.0_rc3 qt6
    
    port to qt6
    
    use xdg instead of xdg-utils for auto pkg_post*
    
    plocales removed (~100K per qm, ~450K per handbook)
    
    custom .desktop removed. belongs to upstream.
    
    depclean:
    boost
    qtwebengine
    
    Closes: https://bugs.gentoo.org/926655
    Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 app-text/bibletime/Manifest                   |  1 +
 app-text/bibletime/bibletime-3.1.0_rc3.ebuild | 45 +++++++++++++++++++++++++++
 2 files changed, 46 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b3b884d4d417457aecd143ca741cc48fc1eef19b

commit b3b884d4d417457aecd143ca741cc48fc1eef19b
Author:     Nicolas PARLANT <nicolas.parlant@parhuet.fr>
AuthorDate: 2025-02-14 11:11:17 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-02-14 13:06:49 +0000

    profiles: Mask qt5 version of app-text/bibletime instead of removal
    
    see: https://github.com/gentoo/gentoo/pull/40563
    
    Bug: https://bugs.gentoo.org/926655
    Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
    Closes: https://github.com/gentoo/gentoo/pull/40563
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/package.mask | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Comment 24 Larry the Git Cow gentoo-dev 2025-02-16 10:51:29 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=43656bbf5e1db675b421099f4cb6616c5fa59688

commit 43656bbf5e1db675b421099f4cb6616c5fa59688
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2025-02-16 10:47:11 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2025-02-16 10:50:43 +0000

    profiles: Drop obsolete app-text/bibletime last-rites mask
    
    Closes: https://github.com/gentoo/gentoo/pull/40568
    Bug: https://bugs.gentoo.org/926655
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 profiles/package.mask | 5 -----
 1 file changed, 5 deletions(-)