Bug 926427 – app-portage/gentoolkit-9999: fixes and changes for new pytest dependency

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Greg Kubaryk 2024-03-08 06:05:54 UTC]

Created attachment 886963 [details, diff]
patch for gentoolkit-9999.ebuild

Regression in 70ea88e3f1e5bdacd8aa6f1eaf30aa0efe2cc114, there is no dep on pytest and building without it (ie, gentoolkit[-test]) fails.

Attached are a patch to the -9999 ebuild and to the gentoolkit sources such that the dependency can be optional.

No rights reserved; please feel free to use the patches with or without credit.

[Comment 1 Greg Kubaryk 2024-03-08 06:06:26 UTC]

Created attachment 886964 [details, diff]
patch for gentoolkit itself to make pytest dep optional

[Comment 2 Zac Medico 2024-03-08 16:25:37 UTC]

(In reply to Greg Kubaryk from comment #1)
> Created attachment 886964 [details, diff] [details, diff]
> patch for gentoolkit itself to make pytest dep optional

This looks good.

(In reply to Greg Kubaryk from comment #0)
> Attached are a patch to the -9999 ebuild and to the gentoolkit sources such
> that the dependency can be optional.
> 
> No rights reserved; please feel free to use the patches with or without
> credit.

We'd like to give you credit, we just need to say that you've signed it off to comply with our Certificate of Origin policy:

https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin

[Comment 3 Greg Kubaryk 2024-03-08 18:10:51 UTC]

(In reply to Zac Medico from comment #2)
> (In reply to Greg Kubaryk from comment #1)
> > Created attachment 886964 [details, diff] [details, diff] [details, diff]
> > patch for gentoolkit itself to make pytest dep optional
> 
> This looks good.
> 
> (In reply to Greg Kubaryk from comment #0)
> > Attached are a patch to the -9999 ebuild and to the gentoolkit sources such
> > that the dependency can be optional.
> > 
> > No rights reserved; please feel free to use the patches with or without
> > credit.
> 
> We'd like to give you credit, we just need to say that you've signed it off
> to comply with our Certificate of Origin policy:
> 
> https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin

I sign accordingly; you can use the name/email from bgo.

[Comment 4 Larry the Git Cow 2024-03-12 21:43:06 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=988e47557368df49035eeba94beca893f7b267c1

commit 988e47557368df49035eeba94beca893f7b267c1
Author:     Sam James <[e-mail]>
AuthorDate: 2024-03-12 21:41:48 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-12 21:41:48 +0000

    meson: make tests optional
    
    Closes: https://bugs.gentoo.org/926427
    Signed-off-by: Greg Kubaryk <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 meson.build       | 6 ++++--
 meson_options.txt | 4 ++++
 2 files changed, 8 insertions(+), 2 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=91b74fc8105b7e08a04da4daef9283fc69bf5f85

commit 91b74fc8105b7e08a04da4daef9283fc69bf5f85
Author:     Sam James <[e-mail]>
AuthorDate: 2024-03-12 21:42:46 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-12 21:42:56 +0000

    ci: enable new test option
    
    See 988e47557368df49035eeba94beca893f7b267c1.
    
    Bug: https://bugs.gentoo.org/926427
    Signed-off-by: Sam James <[e-mail]>

 .github/workflows/ci.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[Comment 5 Larry the Git Cow 2024-03-12 21:43:45 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=d00c9f8b80d8f6193810e7cb4b9175c498fc9c82

commit d00c9f8b80d8f6193810e7cb4b9175c498fc9c82
Author:     Greg Kubaryk <[e-mail]>
AuthorDate: 2024-03-12 21:41:48 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-12 21:43:41 +0000

    meson: make tests optional
    
    Closes: https://bugs.gentoo.org/926427
    Signed-off-by: Greg Kubaryk <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>
    (cherry picked from commit 988e47557368df49035eeba94beca893f7b267c1)

 meson.build       | 6 ++++--
 meson_options.txt | 4 ++++
 2 files changed, 8 insertions(+), 2 deletions(-)

[Comment 6 Sam James 2024-03-12 21:43:59 UTC]

(Sorry, messed up the authorship first time.)

[Comment 7 Larry the Git Cow 2024-03-12 21:46:32 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d129a341c240c68effcb2a03399ea52f36116aea

commit d129a341c240c68effcb2a03399ea52f36116aea
Author:     Sam James <[e-mail]>
AuthorDate: 2024-03-12 21:46:02 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2024-03-12 21:46:25 +0000

    app-portage/gentoolkit: adapt live to new pytest dep + build system option
    
    Closes: https://bugs.gentoo.org/926427
    Co-authored-by: Greg Kubaryk <[e-mail]>
    Signed-off-by: Greg Kubaryk <[e-mail]>
    Signed-off-by: Sam James <[e-mail]>

 app-portage/gentoolkit/gentoolkit-9999.ebuild | 6 ++++++
 1 file changed, 6 insertions(+)