Currently, net-misc/minidlna contains a gentoo patch to change the original icon and images to Gentoo logos unconditionally. I suggest adopting the IUSE branding like other packages (like ie app-office/libreoffice) to apply the patch conditionally and thus enabling user patches which also modify branding stuff to be sourced from original version rather than Gentoo's modified version Reproducible: Always
Aditionally, LTO is supported conditionally into its configure script so it can be added as another IUSE.
Created attachment 886710 [details] minidlna-1.3.3-r1.ebuild Proposed ebuild with changes: * Conditionally download and apply branding patch * Conditionally enable LTO based on IUSE * Clean empty test function
Gentoo recently removed all IUSE for lto, the general recommendation now is to rely on enabling LTO via *FLAGS inside make.conf. In cases where the build system needs to take specific care when enabling LTO, you can use tc-is-lto to detect whether the user has enabled LTO, and filter-lto to force LTO off. In this case specifically it looks like the --enable-lto flag just decides whether to update: CFLAGS="$CFLAGS -flto" so I think the best course of action here is to do nothing.
(In reply to Eli Schwartz from comment #3) > Gentoo recently removed all IUSE for lto, the general recommendation now is > to rely on enabling LTO via *FLAGS inside make.conf. > > In cases where the build system needs to take specific care when enabling > LTO, you can use tc-is-lto to detect whether the user has enabled LTO, and > filter-lto to force LTO off. > > In this case specifically it looks like the --enable-lto flag just decides > whether to update: > > CFLAGS="$CFLAGS -flto" > > so I think the best course of action here is to do nothing. Thanks for the hint! So what about the other branding IUSE proposal?
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a46e572204421e096e418c826523a674e9b5621 commit 0a46e572204421e096e418c826523a674e9b5621 Author: David C. Manuelda <StormByte@gmail.com> AuthorDate: 2025-04-07 23:30:01 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2025-04-08 04:45:08 +0000 net-misc/minidlna: Add IUSE branding for Gentoo artwork icon Closes: https://bugs.gentoo.org/926157 Signed-off-by: David C. Manuelda <StormByte@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/41494 Signed-off-by: Michał Górny <mgorny@gentoo.org> net-misc/minidlna/minidlna-1.3.3.ebuild | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
