Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 925876 - x11-base/xorg-server-21.1.11 fails to compile: ephyr_glamor_xv.c:154:31: error: assignment to SetPortAttributeFuncPtr {aka int ()(struct _KdScreenInfo , long unsigned int, int, void )} from incompatible pointer type int ()(KdScreenInfo , Atom, INT32, voi
Summary: x11-base/xorg-server-21.1.11 fails to compile: ephyr_glamor_xv.c:154:31: erro...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo X packagers
URL:
Whiteboard: fixed in 21.1.13-r1
Keywords: PullRequest
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2024-02-29 21:09 UTC by Agostino Sarubbo
Modified: 2024-11-01 14:24 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build.log (build.log,894.39 KB, text/plain)
2024-02-29 21:09 UTC, Agostino Sarubbo 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2024-02-29 21:09:13 UTC 
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: x11-base/xorg-server-21.1.11 fails to compile.
Discovered on: x86 (internal ref: tinderbox_x86)
System: GCC-14-SYSTEM (https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#GCC-14)

Info about the issue:
https://wiki.gentoo.org/wiki/Project:Tinderbox/Common_Issues_Helper#CF0003
Comment 1 Agostino Sarubbo gentoo-dev 2024-02-29 21:09:15 UTC 
Created attachment 886397 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2024-02-29 21:09:16 UTC 
Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: hw/kdrive/ephyr/Xephyr.p/ephyr_glamor_xv.c.o 
Program fop found: NO
Program rendercheck found: NO
Run-time dependency libsystemd found: NO (tried pkgconfig and cmake)
Run-time dependency libsystemd-daemon found: NO (tried pkgconfig and cmake)
Run-time dependency xorg-sgml-doctools found: NO (tried pkgconfig and cmake)
../xorg-server-21.1.11/hw/kdrive/ephyr/ephyr_glamor_xv.c:154:31: error: assignment to ‘SetPortAttributeFuncPtr’ {aka ‘int (*)(struct _KdScreenInfo *, long unsigned int,  int,  void *)’} from incompatible pointer type ‘int (*)(KdScreenInfo *, Atom,  INT32,  void *)’ {aka ‘int (*)(struct _KdScreenInfo *, long unsigned int,  long int,  void *)’} [-Wincompatible-pointer-types]
Comment 3 Gabi Falk 2024-05-11 11:56:19 UTC 
This one is fixed upstream (see https://gitlab.freedesktop.org/xorg/xserver/-/commit/e89edec497bac581ca9b614fb00c25365580f045).
Comment 4 Gabi Falk 2024-05-12 11:51:17 UTC 
(In reply to Gabi Falk from comment #3)
> This one is fixed upstream (see
> https://gitlab.freedesktop.org/xorg/xserver/-/commit/
> e89edec497bac581ca9b614fb00c25365580f045).

I also made a merge request upstream to backport the fix to the 21.1 branch:
https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1532
Comment 5 Gabi Falk 2024-05-13 21:04:35 UTC 
(In reply to Gabi Falk from comment #4)
> (In reply to Gabi Falk from comment #3)
> > This one is fixed upstream (see
> > https://gitlab.freedesktop.org/xorg/xserver/-/commit/
> > e89edec497bac581ca9b614fb00c25365580f045).
> 
> I also made a merge request upstream to backport the fix to the 21.1 branch:
> https://gitlab.freedesktop.org/xorg/xserver/-/merge_requests/1532
It's merged now.
Comment 6 Larry the Git Cow gentoo-dev 2024-05-21 11:48:57 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=509f72b7bab93d0aa2a5ff1260937f958fdd560b

commit 509f72b7bab93d0aa2a5ff1260937f958fdd560b
Author:     Gabi Falk <gabifalk@gmx.com>
AuthorDate: 2024-05-11 13:00:00 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-21 11:48:20 +0000

    x11-base/xorg-server: backport upstream patch to port to modern C (C99)
    
    Closes: https://bugs.gentoo.org/925876
    Link: https://gitlab.freedesktop.org/xorg/xserver/-/commit/e89edec497bac581ca9b614fb00c25365580f045
    Signed-off-by: Gabi Falk <gabifalk@gmx.com>
    Closes: https://github.com/gentoo/gentoo/pull/36640
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/xorg-server-21.1.10-fix-c99-32bit.patch  | 54 ++++++++++++++++++++++
 ...1.1.13.ebuild => xorg-server-21.1.13-r1.ebuild} |  2 +
 2 files changed, 56 insertions(+)