Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 925726 - app-editors/retext-8.0.1 desktop entry problems
Summary: app-editors/retext-8.0.1 desktop entry problems
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Philipp Rösner
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2024-02-28 19:26 UTC by Chris Mayo
Modified: 2024-03-18 20:04 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Mayo 2024-02-28 19:26:49 UTC
app-editors/retext-8.0.1 installs a desktop entry for each Python implementation.

With two Python PYTHON_TARGETS:

/usr/share/applications/retext.desktop
/usr/share/applications/retext-1.desktop

make_desktop_entry is within python_install()

Also package provides me.mitya57.ReText.desktop and uses this filename with setDesktopFileName() which means GNOME using Wayland does not associate the application icon with the running application.
Comment 1 Larry the Git Cow gentoo-dev 2024-03-18 20:04:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=68989ea42eac5131c0d66f6790cf0ff2e0f3b9b8

commit 68989ea42eac5131c0d66f6790cf0ff2e0f3b9b8
Author:     Philipp Rösner <rndxelement@protonmail.com>
AuthorDate: 2024-03-12 19:48:42 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2024-03-18 20:02:29 +0000

    app-editors/retext: fix desktop file issues
    
    Move desktop file installation from python_install()
    to src_install(). Also, patch __main__.py to use the
    name "retext" for the desktop file (improves desktop
    environment compatibility).
    
    Closes: https://bugs.gentoo.org/925726
    Signed-off-by: Philipp Rösner <rndxelement@protonmail.com>
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 .../files/retext-8.0.1-fix-set-desktop-entry.patch | 15 ++++
 app-editors/retext/retext-8.0.1-r1.ebuild          | 85 ++++++++++++++++++++++
 2 files changed, 100 insertions(+)