The 23.0 profile sets -cli in profiles/releases/23.0/make.defaults If mpv is built without cli then smplayer does not work with it.
(In reply to jospezial from comment #0) > The 23.0 profile sets -cli in profiles/releases/23.0/make.defaults > If mpv is built without cli then smplayer does not work with it. For mpv's end, USE=cli is already default regardless (from the ebuild), but the profile disables it because of how it's handled. Are we supposed to add it to package.use in the profile?
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6522bf905272ffb0b4df763f09dd944069858c09 commit 6522bf905272ffb0b4df763f09dd944069858c09 Author: Ionen Wolkens <ionen@gentoo.org> AuthorDate: 2024-02-28 11:56:01 +0000 Commit: Ionen Wolkens <ionen@gentoo.org> CommitDate: 2024-02-28 12:11:23 +0000 profiles/releases/23.0/package.use: re-enable USE=cli on mpv Already default in the ebuild, but the profile's USE="-cli" causes that to be overridden. Hoping that this is a temporary workaround and there is a better way to handle this in the profile, pretty sure the idea was to no longer enable cli by default, not disable by default. Bug: https://bugs.gentoo.org/925520 Signed-off-by: Ionen Wolkens <ionen@gentoo.org> profiles/releases/23.0/package.use | 6 ++++++ 1 file changed, 6 insertions(+)
I still think it would be the right way to add the usedep to smplayer ebuild.
(In reply to jospezial from comment #3) > I still think it would be the right way to add the usedep to smplayer ebuild. Yes I never said it shouldn't, I would've closed the bug otherwise.
(In reply to Ionen Wolkens from comment #4) > (In reply to jospezial from comment #3) > > I still think it would be the right way to add the usedep to smplayer ebuild. > Yes I never said it shouldn't, I would've closed the bug otherwise. (not that smplayer is a package I typically handle or ever tried, so haven't looked at it myself)
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b29bdf91eff134ec14e92b3824961fc84a04940d commit b29bdf91eff134ec14e92b3824961fc84a04940d Author: Andreas K. Hüttel <dilfridge@gentoo.org> AuthorDate: 2024-03-22 19:34:05 +0000 Commit: Andreas K. Hüttel <dilfridge@gentoo.org> CommitDate: 2024-03-22 19:36:57 +0000 profiles: Move default-on of USE=cli to 17.0 directory, so it can be "unset" in 23.0 This way the default can be overridden by in-ebuild use defaults. Bug: https://bugs.gentoo.org/831045 Bug: https://bugs.gentoo.org/925520 Closes: https://bugs.gentoo.org/927217 Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org> profiles/default/linux/make.defaults | 5 ++++- profiles/releases/17.0/make.defaults | 3 ++- profiles/releases/23.0/make.defaults | 3 --- 3 files changed, 6 insertions(+), 5 deletions(-)
