Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 925441 - sci-libs/opencascade-7.7.0-r2: fix tbb detection
Summary: sci-libs/opencascade-7.7.0-r2: fix tbb detection
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Paul Zander
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2024-02-24 19:00 UTC by Fabio Rossi
Modified: 2024-03-25 18:57 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
opencascade-7.7.0-tbb-detection.patch (opencascade-7.7.0-tbb-detection.patch,2.27 KB, patch)
2024-02-24 19:00 UTC, Fabio Rossi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Rossi 2024-02-24 19:00:12 UTC
Created attachment 885905 [details, diff]
opencascade-7.7.0-tbb-detection.patch

opencascade-7.7.0 fails to detect TBB libraries and for this reason the USE=tbb has been masked. 

I have patched the source to fix the issue, it is due to the fact that Gentoo sets CMAKE_BUILD_TYPE != Release for all cmake-based projects while opencascade cmakefiles assume TBB sources have been build in Release configuration.

I have also reported upstream the problem

https://tracker.dev.opencascade.org/view.php?id=33612
Comment 1 Fabio Rossi 2024-02-24 19:01:22 UTC
of course the masking of TBB useflag can be removed with this patch
Comment 2 Andrew Nowa Ammerlaan gentoo-dev 2024-03-23 09:38:54 UTC
In version 7.8.0 the tbb flag is no longer masked, however this fix is not included and configure still fails to find tbb:

-- Info: The directories of 3rdparty headers:
/usr/include
/usr/include/vtk-9.3
CMake Error at CMakeLists.txt:889 (message):
Could not find libraries of used third-party products:
3RDPARTY_TBB_LIBRARY_DIR 3RDPARTY_TBBMALLOC_LIBRARY_DIR
Comment 3 Fabio Rossi 2024-03-23 09:44:13 UTC
the patch is not upstreamed yet (maybe scheduled for 7.8.1+) so the ebuild must include it until then
Comment 4 Larry the Git Cow gentoo-dev 2024-03-23 09:48:48 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ae4ecc96b3790ef10473b456f15443ca2e882cf0

commit ae4ecc96b3790ef10473b456f15443ca2e882cf0
Author:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
AuthorDate: 2024-03-23 09:47:13 +0000
Commit:     Andrew Ammerlaan <andrewammerlaan@gentoo.org>
CommitDate: 2024-03-23 09:48:17 +0000

    profiles/base: extend tbb mask in opencascade
    
    Bug: https://bugs.gentoo.org/925441
    Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>

 profiles/base/package.use.mask | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Fabio Rossi 2024-03-23 10:10:05 UTC
instead of useflag masking, why don't you include the patch for the ebuild? the aim of this bug report is to improve the current situation, not preserving the status
Comment 6 Andrew Nowa Ammerlaan gentoo-dev 2024-03-23 10:51:55 UTC
(In reply to Fabio Rossi from comment #5)
> instead of useflag masking, why don't you include the patch for the ebuild?
> the aim of this bug report is to improve the current situation, not
> preserving the status

Because testing the patch costs me significantly more time, which I do not have right now. Also, I am not the maintainer of this package, I simply extended the mask as a stopgap solution.
Comment 7 Larry the Git Cow gentoo-dev 2024-03-25 18:57:08 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e3179b6eab5b0d068a54ff39f17cddd9457adcc3

commit e3179b6eab5b0d068a54ff39f17cddd9457adcc3
Author:     Paul Zander <negril.nx+gentoo@gmail.com>
AuthorDate: 2024-03-25 16:16:46 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-03-25 18:54:50 +0000

    sci-libs/opencascade: fix 927629, 927592, 925441
    
    Closes: https://bugs.gentoo.org/927629
    Closes: https://bugs.gentoo.org/927592
    Closes: https://bugs.gentoo.org/925441
    Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/35912
    Signed-off-by: Sam James <sam@gentoo.org>

 profiles/base/package.use.mask                     |  2 +-
 .../files/opencascade-7.7.0-tbb-detection.patch    | 53 ++++++++++++++++++++++
 sci-libs/opencascade/opencascade-7.7.1.ebuild      | 41 ++++++-----------
 sci-libs/opencascade/opencascade-7.7.2.ebuild      | 41 ++++++-----------
 sci-libs/opencascade/opencascade-7.8.0.ebuild      | 30 ++++++------
 5 files changed, 96 insertions(+), 71 deletions(-)