Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 925440 - sys-auth/polkit: fails with test useflag error: implicit declaration of function ‘print_indent’ [-Wimplicit-function-declaration]
Summary: sys-auth/polkit: fails with test useflag error: implicit declaration of funct...
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Freedesktop bugs
URL:
Whiteboard: fixed in 124-r1
Keywords: PullRequest
Depends on:
Blocks: c99-porting
  Show dependency tree
 
Reported: 2024-02-24 18:55 UTC by Christopher Fore
Modified: 2024-11-01 14:23 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,155.86 KB, text/x-log)
2024-02-24 18:55 UTC, Christopher Fore
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Fore 2024-02-24 18:55:50 UTC
Created attachment 885904 [details]
build.log

Steps to reproduce:
1. Set test useflag on sys-auth/polkit
2. Emerge sys-auth/polkit with GCC 14

$ emerge --info
Portage 3.0.61 (python 3.10.13-final-0, default/linux/amd64/23.0/desktop, gcc-14, glibc-2.38-r11, 6.7.5-gentoo-dist x86_64)
=================================================================
System uname: Linux-6.7.5-gentoo-dist-x86_64-AMD_Ryzen_9_5900HX_with_Radeon_Graphics-with-glibc2.38
KiB Mem:    32184536 total,  13753596 free
KiB Swap:    8011772 total,   5444712 free
Timestamp of repository guru: Thu, 22 Feb 2024 01:33:25 +0000
Head commit of repository guru: 94250aba5b699a60507e82b5cd50086aaf84ec40

Head commit of repository kubler: 3f06304ffc1d6d3864b354c85fd4572c33465d8e

Head commit of repository librewolf: ff2acece4624decc10ee90cbe70127bc38f7f940

Head commit of repository mate-overlay: 3ba56f84f4d42de5c62730631fea087f73fe669a

Timestamp of repository pf4public: Wed, 21 Feb 2024 20:33:26 +0000
Head commit of repository pf4public: b0e387c744ed8131ead7f990d6c9af6cfd5affb7

Timestamp of repository riscv: Mon, 12 Feb 2024 16:36:11 +0000
Head commit of repository riscv: 9187e7840b1040c7109d2eda25368d68c579d7b5

Timestamp of repository steam-overlay: Fri, 16 Feb 2024 23:18:24 +0000
Head commit of repository steam-overlay: 214f4d5b11850f9751ee0939df3dd2aaaaef6d26

Timestamp of repository tex-overlay: Wed, 21 Feb 2024 09:33:17 +0000
Head commit of repository tex-overlay: 4c58fdda6a8e35f49e6850848461460e0c486c4f

Head commit of repository gentoo: 5e22a3e7f0ceb1f050498bde29d3d2885a47c51e

sh dash 0.5.12
ld GNU ld (Gentoo 2.42 p3) 2.42.0
app-misc/pax-utils:        1.3.7::gentoo
app-shells/bash:           5.2_p26::gentoo
dev-build/autoconf:        2.13-r8::gentoo, 2.72-r1::gentoo
dev-build/automake:        1.16.5-r2::gentoo
dev-build/cmake:           3.27.7::local
dev-build/libtool:         2.4.7-r2::gentoo
dev-build/make:            4.4.1-r1::gentoo
dev-build/meson:           1.3.2::gentoo
dev-java/java-config:      2.3.3-r1::gentoo
dev-lang/perl:             5.38.2-r1::gentoo
dev-lang/python:           3.11.8_p1::gentoo, 3.12.2_p1::gentoo, 3.13.0_alpha4::gentoo
dev-lang/rust:             1.75.0-r1::gentoo
sys-apps/baselayout:       2.14-r2::gentoo
sys-apps/openrc:           0.53::gentoo
sys-apps/sandbox:          2.38::gentoo
sys-devel/binutils:        2.42-r1::gentoo
sys-devel/binutils-config: 5.5::gentoo
sys-devel/clang:           16.0.6::gentoo, 17.0.6::gentoo
sys-devel/gcc:             11.4.1_p20240208::gentoo, 12.3.1_p20240209::gentoo, 13.2.1_p20240210::gentoo, 14.0.1_pre20240218::gentoo
sys-devel/gcc-config:      2.11::gentoo
sys-devel/lld:             16.0.6::gentoo, 17.0.6::gentoo
sys-devel/llvm:            16.0.6::gentoo, 17.0.6::gentoo
sys-kernel/linux-headers:  6.7::gentoo (virtual/os-headers)
sys-libs/glibc:            2.38-r11::gentoo
Repositories:

guru
    location: /var/db/repos/guru
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/guru.git
    masters: gentoo
    volatile: False

kubler
    location: /var/db/repos/kubler
    sync-type: git
    sync-uri: https://github.com/edannenberg/kubler-overlay.git
    masters: gentoo
    volatile: False

librewolf
    location: /var/db/repos/librewolf
    sync-type: git
    sync-uri: https://codeberg.org/librewolf/gentoo.git
    masters: gentoo
    volatile: False

mate-overlay
    location: /var/db/repos/mate-overlay
    sync-type: git
    sync-uri: https://github.com/immolo/mate-overlay.git
    masters: gentoo
    volatile: False

pf4public
    location: /var/db/repos/pf4public
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/pf4public.git
    masters: gentoo
    volatile: False

riscv
    location: /var/db/repos/riscv
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/riscv.git
    masters: gentoo
    volatile: False

steam-overlay
    location: /var/db/repos/steam-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/steam-overlay.git
    masters: gentoo
    volatile: False

tex-overlay
    location: /var/db/repos/tex-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/tex-overlay.git
    masters: gentoo
    volatile: False

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo
    priority: 10
    volatile: False

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://github.com/gentoo/gentoo
    priority: 1000
    volatile: False

local
    location: /var/db/repos/local
    masters: gentoo
    priority: 9999
    volatile: False

Installed sets: @gcc-testing
ACCEPT_KEYWORDS="amd64 x86 ~amd64 ~x86"
ACCEPT_LICENSE="* @FREE @BINARY-REDISTRIBUTABLE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O3 -fno-semantic-interposition -ftrivial-auto-var-init=zero -pipe -fdiagnostics-color=always"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.9/conf"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O3 -fno-semantic-interposition -ftrivial-auto-var-init=zero -pipe -fdiagnostics-color=always"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GDK_PIXBUF_MODULE_FILE GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-march=native -O3 -fno-semantic-interposition -ftrivial-auto-var-init=zero -pipe -fdiagnostics-color=always"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg buildpkg-live candy config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox pkgdir-index-trusted preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=native -O3 -fno-semantic-interposition -ftrivial-auto-var-init=zero -pipe -fdiagnostics-color=always"
GENTOO_MIRRORS="https://mirrors.rit.edu/gentoo/"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs"
LEX="flex"
MAKEOPTS="-j10"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="X a52 aac acl acpi alsa amd64 bluetooth branding bzip2 cairo cdda cdr crypt cups dbus dri dts dvd dvdr elogind encode exif flac gdbm gif gpm gtk gui iconv icu ipv6 jpeg lcms libnotify libtirpc lzma mad mng mp3 mp4 mpeg multilib ncurses nls ogg opengl pam pango pcre pdf pipewire png policykit ppds pulseaudio qt5 qt6 readline screencast sdl seccomp sound spell ssl startup-notification svg test-rust tiff truetype udev udisks unicode upower usb vaapi vdpau vorbis vulkan wayland wifi wxwidgets x264 xattr xcb xft xml xv xvid zlib zstd" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_anon authn_dbm authn_file authz_dbm authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir env expires ext_filter file_cache filter headers include info log_config logio mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 aes avx avx2 f16c fma3 pclmul popcnt rdrand sha sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 ntrip navcom oceanserver oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 tsip tripmate tnt ublox" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz glk hd44780 lb216 lcdm001 mtxorb text" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php8-1" POSTGRES_TARGETS="postgres15" PYTHON_SINGLE_TARGET="python3_11" PYTHON_TARGETS="python3_11 python3_12 pypy3" RUBY_TARGETS="ruby31" VIDEO_CARDS="amdgpu radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipp2p iface geoip fuzzy condition tarpit sysrq proto logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PYTHONPATH, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-02-24 18:57:31 UTC
Please keep in mind you should not set USE=test manually and it's near-meaningless.

You need to do FEATURES=test.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2024-02-24 19:05:46 UTC
(In reply to Sam James from comment #1)
> Please keep in mind you should not set USE=test manually and it's
> near-meaningless.
> 
> You need to do FEATURES=test.

The ebuild has:

# https://gitlab.freedesktop.org/polkit/polkit/-/issues/181 for test restriction
RESTRICT="!test? ( test ) test"

# This seems to be fixed with 121?
#if [[ ${PV} == *_p* ]] ; then
#	RESTRICT="!test? ( test )"
#else
#	# Tests currently don't work with meson in the dist tarballs. See
#	#  https://gitlab.freedesktop.org/polkit/polkit/-/issues/144
#	RESTRICT="test"
#fi

so I'll call this INVALID.
Comment 3 Christopher Fore 2024-02-24 19:49:53 UTC
(In reply to Sam James from comment #1)
> Please keep in mind you should not set USE=test manually and it's
> near-meaningless.
> 
> You need to do FEATURES=test.

Ah my apologies, I did run into this with FEATURES=test on another box but I saw it hit this when using test in USE to pull in the test deps. While reading this, I did remember that there is an emerge flag to pull in test deps but it had been a while since having to pull in test deps.


w.r.t the test error, I think what does needs to be done is removing `$(meson_use test tests)` (or disabling it somehow?) since this will always be set regardless if the test phase is restricted, right? The error itself is in building mocklibc and not *actually* running the tests.
Comment 4 Larry the Git Cow gentoo-dev 2024-05-03 12:16:17 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1521587bb323049922809b7756705792564041a7

commit 1521587bb323049922809b7756705792564041a7
Author:     Kostadin Shishmanov <kocelfc@tutanota.com>
AuthorDate: 2024-05-03 11:37:06 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2024-05-03 12:12:54 +0000

    sys-auth/polkit: fix tests
    
    Reenable tests with FEATURES="test" and backport test build error fix
    for C99 compilers.
    
    Bug: https://bugs.gentoo.org/925440
    Signed-off-by: Kostadin Shishmanov <kocelfc@tutanota.com>
    Closes: https://github.com/gentoo/gentoo/pull/36527
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-auth/polkit/files/polkit-124-c99-fixes.patch | 111 +++++++++++++++++++++++
 sys-auth/polkit/polkit-124-r1.ebuild             |  13 +--
 2 files changed, 113 insertions(+), 11 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2024-11-01 14:23:13 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a8d1fdb294af26b3ba1797886ab9f1e49867ef73

commit a8d1fdb294af26b3ba1797886ab9f1e49867ef73
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2024-11-01 14:22:30 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2024-11-01 14:23:02 +0000

    sys-auth/polkit: drop 123
    
    Bug: https://bugs.gentoo.org/925440
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 sys-auth/polkit/Manifest                           |   1 -
 sys-auth/polkit/files/polkit-123-mozjs-JIT.patch   |  36 -----
 .../files/polkit-123-pkexec-uninitialized.patch    |  35 -----
 sys-auth/polkit/polkit-123.ebuild                  | 162 ---------------------
 4 files changed, 234 deletions(-)